Chromium Code Reviews| Index: src/compiler.h |
| diff --git a/src/compiler.h b/src/compiler.h |
| index 66fa865d6fe02c42334ccfafb8bbbad20e901341..7d327ab796e7f464a51850525a46796746782aba 100644 |
| --- a/src/compiler.h |
| +++ b/src/compiler.h |
| @@ -139,7 +139,7 @@ struct InlinedFunctionInfo { |
| // CompilationInfo encapsulates some information known at compile time. It |
| // is constructed based on the resources available at compile-time. |
| -class CompilationInfo { |
| +class CompilationInfo final BASE_EMBEDDED { |
|
Benedikt Meurer
2016/04/28 10:23:02
Please don't use the BASE_EMBEDDED macro.
Michael Starzinger
2016/05/02 12:35:05
Done.
|
| public: |
| // Various configuration flags for a compilation, as well as some properties |
| // of the compiled code produced by a compilation. |
| @@ -167,7 +167,7 @@ class CompilationInfo { |
| CompilationInfo(ParseInfo* parse_info, Handle<JSFunction> closure); |
| CompilationInfo(Vector<const char> debug_name, Isolate* isolate, Zone* zone, |
| Code::Flags code_flags = Code::ComputeFlags(Code::STUB)); |
| - virtual ~CompilationInfo(); |
| + ~CompilationInfo(); |
| ParseInfo* parse_info() const { return parse_info_; } |
| @@ -573,7 +573,6 @@ class CompilationInfo { |
| // as well. When failing we distinguish between the following levels: |
| // a) AbortOptimization: Persistent failure, disable future optimization. |
| // b) RetryOptimzation: Transient failure, try again next time. |
| -// TODO(mstarzinger): Make CompilationInfo base embedded. |
| class CompilationJob { |
| public: |
| explicit CompilationJob(CompilationInfo* info, const char* compiler_name) |