Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Side by Side Diff: ppapi/BUILD.gn

Issue 1930773002: Always set symbol visibility when compiling with GCC / Clang. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: sync Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/features.gni") 5 import("//build/config/features.gni")
6 6
7 assert(!is_android || enable_plugins, 7 assert(!is_android || enable_plugins,
8 "//ppapi should not be referenced when is_android && !enable_plugins") 8 "//ppapi should not be referenced when is_android && !enable_plugins")
9 9
10 if (is_mac) { 10 if (is_mac) {
(...skipping 229 matching lines...) Expand 10 before | Expand all | Expand 10 after
240 "//build/win:default_exe_manifest", 240 "//build/win:default_exe_manifest",
241 ] 241 ]
242 } 242 }
243 243
244 if (is_nacl_glibc) { 244 if (is_nacl_glibc) {
245 shared_library("ppapi_cpp_lib") { 245 shared_library("ppapi_cpp_lib") {
246 # When using gcc, we hide all symbols by default, but that breaks at 246 # When using gcc, we hide all symbols by default, but that breaks at
247 # link time as the test executable requires symbols defined in the 247 # link time as the test executable requires symbols defined in the
248 # shared library. 248 # shared library.
249 configs -= [ "//build/config/gcc:symbol_visibility_hidden" ] 249 configs -= [ "//build/config/gcc:symbol_visibility_hidden" ]
250 configs += [ "//build/config/gcc:symbol_visibility_default" ]
250 251
251 sources = ppapi_sources.cpp_source_files 252 sources = ppapi_sources.cpp_source_files
252 sources += [ 253 sources += [
253 "cpp/module_embedder.h", 254 "cpp/module_embedder.h",
254 "cpp/ppp_entrypoints.cc", 255 "cpp/ppp_entrypoints.cc",
255 ] 256 ]
256 cflags = [ "-fPIC" ] 257 cflags = [ "-fPIC" ]
257 deps = [ 258 deps = [
258 "//build/config/nacl:nacl_base", 259 "//build/config/nacl:nacl_base",
259 ] 260 ]
(...skipping 183 matching lines...) Expand 10 before | Expand all | Expand 10 after
443 group("ppapi_nacl_tests_all") { 444 group("ppapi_nacl_tests_all") {
444 data_deps = [ 445 data_deps = [
445 ":copy_test_files", 446 ":copy_test_files",
446 ":ppapi_nacl_tests_copy(//build/toolchain/nacl:clang_newlib_${target_cpu}) ", 447 ":ppapi_nacl_tests_copy(//build/toolchain/nacl:clang_newlib_${target_cpu}) ",
447 ":ppapi_nacl_tests(//build/toolchain/nacl:glibc_${target_cpu})", 448 ":ppapi_nacl_tests(//build/toolchain/nacl:glibc_${target_cpu})",
448 ":ppapi_nacl_tests(//build/toolchain/nacl:newlib_pnacl)", 449 ":ppapi_nacl_tests(//build/toolchain/nacl:newlib_pnacl)",
449 ":ppapi_nacl_tests(//build/toolchain/nacl:newlib_pnacl_nonsfi)", 450 ":ppapi_nacl_tests(//build/toolchain/nacl:newlib_pnacl_nonsfi)",
450 ] 451 ]
451 } 452 }
452 } 453 }
OLDNEW
« no previous file with comments | « ios/third_party/ochamcrest/BUILD.gn ('k') | ppapi/native_client/src/untrusted/irt_stub/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698