Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(622)

Issue 193073003: rebaseline_server: disable image magnifier, for huge UI speedup (Closed)

Created:
6 years, 9 months ago by epoger
Modified:
6 years, 9 months ago
Reviewers:
rmistry
CC:
skia-review_googlegroups.com, borenet, bsalomon, robertphillips
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

rebaseline_server: disable image magnifier, for huge UI speedup BUG=skia:2248 NOTREECHECKS=True NOTRY=True TBR=rmistry Committed: http://code.google.com/p/skia/source/detail?r=13727

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -197 lines) Patch
D gm/rebaseline_server/static/diff_viewer.js View 1 chunk +0 lines, -177 lines 0 comments Download
M gm/rebaseline_server/static/loader.js View 1 chunk +1 line, -1 line 0 comments Download
M gm/rebaseline_server/static/view.html View 6 chunks +14 lines, -19 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
epoger
Running the "test circuit" in https://goto.google.com/RebaselineServerQuickSpeedupVictories before and after this change, with MAX_RECORDS=300 : BEFORE: ...
6 years, 9 months ago (2014-03-10 19:10:47 UTC) #1
epoger
committing TBR
6 years, 9 months ago (2014-03-10 19:11:08 UTC) #2
epoger
The CQ bit was checked by epoger@google.com
6 years, 9 months ago (2014-03-10 19:11:12 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-10 19:11:13 UTC) #4
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 9 months ago (2014-03-10 19:11:14 UTC) #5
epoger
The CQ bit was checked by epoger@google.com
6 years, 9 months ago (2014-03-10 19:12:24 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/epoger@google.com/193073003/1
6 years, 9 months ago (2014-03-10 19:12:34 UTC) #7
commit-bot: I haz the power
Change committed as 13727
6 years, 9 months ago (2014-03-10 19:12:56 UTC) #8
epoger
6 years, 9 months ago (2014-03-10 19:22:40 UTC) #9
Message was sent while issue was closed.
Filed https://code.google.com/p/skia/issues/detail?id=2283 ('rebaseline_server:
re-enable image magnifier') to track followup work

Powered by Google App Engine
This is Rietveld 408576698