Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 1930723004: Removed DeviceDataManagerX11::scrollclass_devices_ (Closed)

Created:
4 years, 7 months ago by dtapuska
Modified:
4 years, 7 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2704
Target Ref:
refs/pending/branch-heads/2704
Project:
chromium
Visibility:
Public.

Description

Removed DeviceDataManagerX11::scrollclass_devices_ This field isn't needed, and goes against the idea that a mouse either supports scroll classes entirely or not at all. Instead we should use logic that checks whether a device supports horizontal, vertical or both scroll classes. I also fixed some logic that could have passed an invalid validator ID into XIMaskIsSet---this new check covers the check removed above it. BUG=596013 Review URL: https://codereview.chromium.org/1896483002 Cr-Commit-Position: refs/heads/master@{#388208} (cherry picked from commit b89e8ac7021fcee56c7cc34fd077eac253c99d0b) Committed: https://chromium.googlesource.com/chromium/src/+/ef15254ebb53083a61667ea253372d690d61b125

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -7 lines) Patch
M ui/events/devices/x11/device_data_manager_x11.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/events/devices/x11/device_data_manager_x11.cc View 3 chunks +3 lines, -6 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
dtapuska
4 years, 7 months ago (2016-04-28 20:45:51 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ef15254ebb53083a61667ea253372d690d61b125.

Powered by Google App Engine
This is Rietveld 408576698