Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issue 1930723003: Version 5.0.71.40 (cherry-pick) (Closed)

Created:
4 years, 7 months ago by zhengxing.li
Modified:
4 years, 7 months ago
Reviewers:
Michael Hablich
CC:
v8-reviews_googlegroups.com, Paweł Hajdan Jr., ulan
Base URL:
https://chromium.googlesource.com/v8/v8.git@5.0
Target Ref:
refs/pending/branch-heads/5.0
Project:
v8
Visibility:
Public.

Description

Version 5.0.71.40 (cherry-pick) X87: [turbofan] Don't use the CompareIC in JSGenericLowering. This is essentially a cherry-pick that was applied before plus the removal of a test that is now failing because it depends on more involved changes. The test case checks comparison of different undetectable JSReceivers, which is not relevant in practice, as there's only one of these at most, which is document.all. Merged 2aa534105079559235950bafd51d82036f320335 Merged 4a6f15124ff674e8732a342c87ee17731aa721ce X87: [runtime] Unify comparison operator runtime entries. X87: [turbofan] Don't use the CompareIC in JSGenericLowering. R=hablich@chromium.org BUG=v8:4960 LOG=N NOTRY=true NOPRESUBMIT=true

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -10 lines) Patch
M include/v8-version.h View 1 chunk +1 line, -1 line 0 comments Download
M src/x87/code-stubs-x87.cc View 1 chunk +14 lines, -9 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
zhengxing.li
4 years, 7 months ago (2016-04-28 05:21:35 UTC) #1
Michael Hablich
On 2016/04/28 05:21:35, zhengxing.li wrote: lgtm ... please always include a link to an issue ...
4 years, 7 months ago (2016-04-28 09:27:54 UTC) #3
zhengxing.li
On 2016/04/28 09:27:54, Hablich wrote: > On 2016/04/28 05:21:35, zhengxing.li wrote: > > lgtm ...
4 years, 7 months ago (2016-04-28 09:31:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1930723003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1930723003/1
4 years, 7 months ago (2016-04-28 09:35:56 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-04-28 09:37:27 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698