Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1045)

Unified Diff: chrome/browser/ssl/ssl_policy.cc

Issue 193063: Fix for an SSL error related crasher (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ssl/ssl_policy.cc
===================================================================
--- chrome/browser/ssl/ssl_policy.cc (revision 25792)
+++ chrome/browser/ssl/ssl_policy.cc (working copy)
@@ -305,8 +305,12 @@
true,
handler->request_url(),
security_info);
- tab->controller().GetActiveEntry()->set_page_type(
- NavigationEntry::ERROR_PAGE);
+
+ // TODO(jcampan): we may want to set the navigation entry type to
+ // PageType::ERROR_PAGE. The navigation entry is not available at this point,
+ // it is created when the rendere receives a DidNavigate (triggered by the
willchan no longer on Chromium 2009/09/10 00:19:16 s/rendere/renderer/
+ // LoadAlternateHTMLString above). We'd probably need to pass the page type
+ // along with the security_info.
}
void SSLPolicy::AddMixedContentWarningToConsole(
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698