Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 193063: Fix for an SSL error related crasher (Closed)

Created:
11 years, 3 months ago by jcampan
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com, Ben Goodger (Google)
Visibility:
Public.

Description

The SSL policy when showing an error page sets the page type on the wrong navigation entry, which can potentially be NULL causing a crasher. Disabling the setting of page type for the error page, since it is not used. BUG=http://crbug.com/19941 TEST=See steps in the bug. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=26056

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M chrome/browser/ssl/ssl_policy.cc View 1 chunk +6 lines, -2 lines 1 comment Download

Messages

Total messages: 3 (0 generated)
jcampan
11 years, 3 months ago (2009-09-09 22:08:42 UTC) #1
willchan no longer on Chromium
It seems to me that it'd be nice to get some test coverage for the ...
11 years, 3 months ago (2009-09-10 00:19:15 UTC) #2
jcampan
11 years, 3 months ago (2009-09-12 00:05:19 UTC) #3
I'll add a browser test to the ssl_browser_test in a next CL (as it requires
adding some APIs to the browser test utils).

Powered by Google App Engine
This is Rietveld 408576698