Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(402)

Issue 1930603004: mojom: move mojom/mojom_tool/generated -> mojom/generated. Update consumers (Closed)

Created:
4 years, 7 months ago by vardhan
Modified:
4 years, 7 months ago
Reviewers:
rudominer, azani
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

mojom: move mojom/mojom_tool/generated -> mojom/generated. Update consumers R=azani@chromium.org, rudominer@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/74e3c9d3a0cce0d8159edc5783f5aca7cfdf078d

Patch Set 1 #

Patch Set 2 : Fix paths to new `generated/` in mojom_tool/BUILD.gn #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -5440 lines) Patch
A + mojom/generated/README.md View 1 chunk +1 line, -1 line 0 comments Download
A + mojom/generated/mojom_files/mojom_files.mojom.go View 1 chunk +1 line, -1 line 0 comments Download
A + mojom/generated/mojom_types/mojom_types.mojom.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M mojom/generators/common/cli.go View 1 chunk +1 line, -1 line 0 comments Download
M mojom/generators/common/common.go View 1 chunk +1 line, -1 line 0 comments Download
M mojom/mojom_tool/BUILD.gn View 1 1 chunk +2 lines, -2 lines 0 comments Download
M mojom/mojom_tool/examples/example_consumer.go View 1 chunk +2 lines, -2 lines 0 comments Download
D mojom/mojom_tool/generated/README.md View 1 chunk +0 lines, -44 lines 0 comments Download
D mojom/mojom_tool/generated/mojom_files/mojom_files.mojom.go View 1 chunk +0 lines, -1189 lines 0 comments Download
D mojom/mojom_tool/generated/mojom_types/mojom_types.mojom.go View 1 chunk +0 lines, -4196 lines 0 comments Download
M mojom/mojom_tool/serialization/serialization.go View 1 chunk +2 lines, -2 lines 0 comments Download
M mojom/mojom_tool/serialization/serialization_test.go View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (1 generated)
vardhan
ptal
4 years, 7 months ago (2016-04-27 23:08:13 UTC) #1
rudominer
bots are red. please fix.
4 years, 7 months ago (2016-04-27 23:11:23 UTC) #2
vardhan
On 2016/04/27 23:11:23, rudominer wrote: > bots are red. please fix. it's because i haven't ...
4 years, 7 months ago (2016-04-28 00:23:50 UTC) #3
azani
On 2016/04/28 00:23:50, vardhan wrote: > On 2016/04/27 23:11:23, rudominer wrote: > > bots are ...
4 years, 7 months ago (2016-04-28 00:34:58 UTC) #4
vardhan
> Well, that's not really the expectation. The expectation is that for some path > ...
4 years, 7 months ago (2016-04-28 01:18:15 UTC) #5
vardhan
> Well, that's not really the expectation. The expectation is that for some path > ...
4 years, 7 months ago (2016-04-28 01:18:16 UTC) #6
rudominer
lgtm
4 years, 7 months ago (2016-04-28 18:24:43 UTC) #7
azani
lgtm
4 years, 7 months ago (2016-04-28 19:33:27 UTC) #8
vardhan
4 years, 7 months ago (2016-04-28 19:35:39 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
74e3c9d3a0cce0d8159edc5783f5aca7cfdf078d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698