Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1930563002:
[Polymer10] Migrate autocomplete-box.html to Polymer 1.0. (Closed)
|
Created:
4 years, 7 months ago by dtu Modified:
4 years, 7 months ago Reviewers:
eakuefner CC:
catapult-reviews_chromium.org, perf-dashboard-reviews_chromium.org Base URL:
https://github.com/catapult-project/catapult.git@polymer10-migration Target Ref:
refs/heads/polymer10-migration Project:
catapult Visibility:
Public. |
Description[Polymer10] Migrate autocomplete-box.html to Polymer 1.0.
BUG=catapult:#2285
R=eakuefner@chromium.org
NOTRY=true
NOPRESUBMIT=true
Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/bb7a21a11fc68ae9875a8e66ae541a540397797b
Patch Set 1 #
Total comments: 4
Patch Set 2 : Fixes. #Messages
Total messages: 16 (9 generated)
Description was changed from ========== [Polymer10] Migrate alerts-table.html to Polymer 1.0. BUG=catapult:#2285 R=eakuefner@chromium.org ========== to ========== [Polymer10] Migrate bisect-status.html to Polymer 1.0. BUG=catapult:#2285 R=eakuefner@chromium.org ==========
Description was changed from ========== [Polymer10] Migrate bisect-status.html to Polymer 1.0. BUG=catapult:#2285 R=eakuefner@chromium.org ========== to ========== [Polymer10] Migrate autocomplete-box.html to Polymer 1.0. BUG=catapult:#2285 R=eakuefner@chromium.org ==========
lgtm https://codereview.chromium.org/1930563002/diff/1/dashboard/dashboard/element... File dashboard/dashboard/elements/autocomplete-box.html (right): https://codereview.chromium.org/1930563002/diff/1/dashboard/dashboard/element... dashboard/dashboard/elements/autocomplete-box.html:102: <paper-input-decorator label="{{placeholder}}" floatinglabel="" layout vertical class="layout vertical" https://codereview.chromium.org/1930563002/diff/1/dashboard/dashboard/element... dashboard/dashboard/elements/autocomplete-box.html:121: hidden$="{{hidden}}" Pointing out that this is weird (as per in person discussion but let's keep it and see what happens and/or breaks.
https://codereview.chromium.org/1930563002/diff/1/dashboard/dashboard/element... File dashboard/dashboard/elements/autocomplete-box.html (right): https://codereview.chromium.org/1930563002/diff/1/dashboard/dashboard/element... dashboard/dashboard/elements/autocomplete-box.html:102: <paper-input-decorator label="{{placeholder}}" floatinglabel="" layout vertical On 2016/04/27 at 19:16:50, eakuefner (slow) wrote: > class="layout vertical" Done. https://codereview.chromium.org/1930563002/diff/1/dashboard/dashboard/element... dashboard/dashboard/elements/autocomplete-box.html:121: hidden$="{{hidden}}" On 2016/04/27 at 19:16:50, eakuefner (slow) wrote: > Pointing out that this is weird (as per in person discussion but let's keep it and see what happens and/or breaks. Acknowledged.
The CQ bit was checked by dtu@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from eakuefner@chromium.org Link to the patchset: https://codereview.chromium.org/1930563002/#ps20001 (title: "Fixes.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1930563002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1930563002/20001
The CQ bit was unchecked by commit-bot@chromium.org
CLs for remote refs other than refs/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for the CQ to process them
Description was changed from ========== [Polymer10] Migrate autocomplete-box.html to Polymer 1.0. BUG=catapult:#2285 R=eakuefner@chromium.org ========== to ========== [Polymer10] Migrate autocomplete-box.html to Polymer 1.0. BUG=catapult:#2285 R=eakuefner@chromium.org NOTRY=True NOPRESUBMIT=True ==========
Description was changed from ========== [Polymer10] Migrate autocomplete-box.html to Polymer 1.0. BUG=catapult:#2285 R=eakuefner@chromium.org NOTRY=True NOPRESUBMIT=True ========== to ========== [Polymer10] Migrate autocomplete-box.html to Polymer 1.0. BUG=catapult:#2285 R=eakuefner@chromium.org NOTRY=true NOPRESUBMIT=true ==========
The CQ bit was checked by dtu@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1930563002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1930563002/20001
Message was sent while issue was closed.
Description was changed from ========== [Polymer10] Migrate autocomplete-box.html to Polymer 1.0. BUG=catapult:#2285 R=eakuefner@chromium.org NOTRY=true NOPRESUBMIT=true ========== to ========== [Polymer10] Migrate autocomplete-box.html to Polymer 1.0. BUG=catapult:#2285 R=eakuefner@chromium.org NOTRY=true NOPRESUBMIT=true Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapu... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/external/github.com/catapult-project/catapu... |
