Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 1930553004: Revert of Rebaseline for 1921493006. (Closed)

Created:
4 years, 7 months ago by robertshield
Modified:
4 years, 7 months ago
Reviewers:
chrishtr
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, sergeyv+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Rebaseline for 1921493006. (patchset #1 id:1 of https://codereview.chromium.org/1927963004/ ) Reason for revert: Revert of Manual rebaseline for crbug.com/475128 and crbug.com/530044 (patchset #1 id:1 of https://codereview.chromium.org/1925213002/ ) Reason for revert: Reverting as this seems to have broken serveral tests: webkit_tests webkit_tests unexpected_failures: printing/fixed-positioned-headers-and-footers-inside-transform.html virtual/threaded/printing/fixed-positioned-headers-and-footers-larger-than-page.html printing/fixed-positioned-headers-and-footers-larger-than-page.html virtual/threaded/printing/iframe-print.html virtual/threaded/printing/subframes-percentage-height.html virtual/threaded/printing/absolute-position-headers-and-footers.html printing/absolute-position-headers-and-footers.html printing/fixed-positioned-but-static-headers-and-footers.html printing/fixed-positioned-headers-and-footers-clipped.html virtual/threaded/printing/fixed-positioned-headers-and-footers.html printing/fixed-positioned-headers-and-footers-absolute-covering-some-pages.html printing/iframe-print.html printing/fixed-positioned-headers-and-footers.html virtual/threaded/printing/fixed-positioned-headers-and-footers-inside-transform.html virtual/threaded/printing/fixed-positioned-but-static-headers-and-footers.html virtual/threaded/printing/fixed-positioned-headers-and-footers-absolute-covering-some-pages.html virtual/threaded/printing/fixed-positioned-headers-and-footers-clipped.html printing/subframes-percentage-height.html Link: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win10/builds/9378 Original issue's description: > Rebaseline for 1921493006. > > TBR=wkorman@chromium.org > BUG=590971 TBR=chrishtr@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=590971 Committed: https://crrev.com/bc50dbff7fa0b25e644d80effef731f169063ad6 Cr-Commit-Position: refs/heads/master@{#390469}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -88 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +20 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/layers/layer-canvas-log-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/platform/android/printing/absolute-position-headers-and-footers-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/android/printing/fixed-positioned-but-static-headers-and-footers-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/android/printing/fixed-positioned-headers-and-footers-absolute-covering-some-pages-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/android/printing/fixed-positioned-headers-and-footers-clipped-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/android/printing/fixed-positioned-headers-and-footers-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/android/printing/fixed-positioned-headers-and-footers-inside-transform-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/android/printing/fixed-positioned-headers-and-footers-larger-than-page-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/android/printing/iframe-print-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/android/printing/subframes-percentage-height-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/android/virtual/threaded/printing/absolute-position-headers-and-footers-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/android/virtual/threaded/printing/fixed-positioned-but-static-headers-and-footers-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/android/virtual/threaded/printing/fixed-positioned-headers-and-footers-absolute-covering-some-pages-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/android/virtual/threaded/printing/fixed-positioned-headers-and-footers-clipped-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/android/virtual/threaded/printing/fixed-positioned-headers-and-footers-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/android/virtual/threaded/printing/fixed-positioned-headers-and-footers-inside-transform-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/android/virtual/threaded/printing/fixed-positioned-headers-and-footers-larger-than-page-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/android/virtual/threaded/printing/iframe-print-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/android/virtual/threaded/printing/subframes-percentage-height-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/printing/absolute-position-headers-and-footers-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/printing/fixed-positioned-but-static-headers-and-footers-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/printing/fixed-positioned-headers-and-footers-absolute-covering-some-pages-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/printing/fixed-positioned-headers-and-footers-clipped-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/printing/fixed-positioned-headers-and-footers-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/printing/fixed-positioned-headers-and-footers-inside-transform-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/printing/fixed-positioned-headers-and-footers-larger-than-page-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/printing/iframe-print-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/printing/subframes-percentage-height-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/virtual/threaded/printing/absolute-position-headers-and-footers-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/virtual/threaded/printing/fixed-positioned-but-static-headers-and-footers-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/virtual/threaded/printing/fixed-positioned-headers-and-footers-absolute-covering-some-pages-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/virtual/threaded/printing/fixed-positioned-headers-and-footers-clipped-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/virtual/threaded/printing/fixed-positioned-headers-and-footers-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/virtual/threaded/printing/fixed-positioned-headers-and-footers-inside-transform-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/virtual/threaded/printing/fixed-positioned-headers-and-footers-larger-than-page-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/virtual/threaded/printing/iframe-print-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/virtual/threaded/printing/iframe-print-expected.txt View 1 chunk +0 lines, -41 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/virtual/threaded/printing/subframes-percentage-height-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/printing/absolute-position-headers-and-footers-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/printing/fixed-positioned-but-static-headers-and-footers-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/printing/fixed-positioned-headers-and-footers-absolute-covering-some-pages-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/printing/fixed-positioned-headers-and-footers-clipped-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/printing/fixed-positioned-headers-and-footers-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/printing/fixed-positioned-headers-and-footers-inside-transform-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/printing/fixed-positioned-headers-and-footers-larger-than-page-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/printing/iframe-print-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/printing/subframes-percentage-height-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/virtual/threaded/printing/absolute-position-headers-and-footers-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/virtual/threaded/printing/fixed-positioned-but-static-headers-and-footers-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/virtual/threaded/printing/fixed-positioned-headers-and-footers-absolute-covering-some-pages-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/virtual/threaded/printing/fixed-positioned-headers-and-footers-clipped-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/virtual/threaded/printing/fixed-positioned-headers-and-footers-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/virtual/threaded/printing/fixed-positioned-headers-and-footers-inside-transform-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/virtual/threaded/printing/fixed-positioned-headers-and-footers-larger-than-page-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/virtual/threaded/printing/iframe-print-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/virtual/threaded/printing/subframes-percentage-height-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/printing/iframe-print-expected.txt View 1 chunk +5 lines, -5 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/virtual/threaded/printing/iframe-print-expected.txt View 1 chunk +0 lines, -41 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win7/printing/absolute-position-headers-and-footers-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win7/printing/fixed-positioned-but-static-headers-and-footers-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win7/printing/fixed-positioned-headers-and-footers-absolute-covering-some-pages-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win7/printing/fixed-positioned-headers-and-footers-clipped-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win7/printing/fixed-positioned-headers-and-footers-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win7/printing/fixed-positioned-headers-and-footers-inside-transform-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win7/printing/fixed-positioned-headers-and-footers-larger-than-page-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win7/printing/iframe-print-expected.png View Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/win7/printing/iframe-print-expected.txt View 1 chunk +41 lines, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win7/printing/subframes-percentage-height-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win7/virtual/threaded/printing/absolute-position-headers-and-footers-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win7/virtual/threaded/printing/fixed-positioned-but-static-headers-and-footers-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win7/virtual/threaded/printing/fixed-positioned-headers-and-footers-absolute-covering-some-pages-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win7/virtual/threaded/printing/fixed-positioned-headers-and-footers-clipped-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win7/virtual/threaded/printing/fixed-positioned-headers-and-footers-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win7/virtual/threaded/printing/fixed-positioned-headers-and-footers-inside-transform-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win7/virtual/threaded/printing/fixed-positioned-headers-and-footers-larger-than-page-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win7/virtual/threaded/printing/iframe-print-expected.png View Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/win7/virtual/threaded/printing/iframe-print-expected.txt View 1 chunk +41 lines, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win7/virtual/threaded/printing/subframes-percentage-height-expected.png View Binary file 0 comments Download

Messages

Total messages: 6 (2 generated)
robertshield
Created Revert of Rebaseline for 1921493006.
4 years, 7 months ago (2016-04-28 20:41:26 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1930553004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1930553004/1
4 years, 7 months ago (2016-04-28 20:42:01 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-04-28 20:43:37 UTC) #4
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:20:52 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bc50dbff7fa0b25e644d80effef731f169063ad6
Cr-Commit-Position: refs/heads/master@{#390469}

Powered by Google App Engine
This is Rietveld 408576698