Issue 1930553002: Revert "Don’t cache constants in initializer expressions"

Issue 1930553002: Revert "Don’t cache constants in initializer expressions" (Closed)

Created:
4 years, 7 months ago by hausner

Modified:
4 years, 7 months ago

Reviewers:
rmacnak

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Revert "Don’t cache constants in initializer expressions" This reverts commit 77b328333f9392673ae50b0820789614dd850a4e. BUG= Committed: https://github.com/dart-lang/sdk/commit/d5d876255198a4492f49db96edf91f8f9dccb529

Created: 4 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -5 lines)			Patch
	M	runtime/vm/parser.cc	View		1 chunk	+0 lines, -5 lines	0 comments	Download

Total messages: 7 (3 generated)

hausner

Committed patchset #1 (id:1) manually as d5d876255198a4492f49db96edf91f8f9dccb529 (presubmit successful).

4 years, 7 months ago (2016-04-27 17:21:26 UTC) #2

hausner

The change broke a stress test (language/vm/optimized_stacktrace_test) in some architectures, but interestingly not on x64. ...

4 years, 7 months ago (2016-04-27 17:22:45 UTC) #5

Message was sent while issue was closed.

lgtm