Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1930533002: More IFX_ interface cleanup. (Closed)

Created:
4 years, 7 months ago by dsinclair
Modified:
4 years, 7 months ago
Reviewers:
Tom Sepez, Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

More IFX_ interface cleanup. Remove IFX_FontProvider, IFX_FontSourceEnum, IFX_SAXReader and IFX_SAXReaderHandler. Committed: https://pdfium.googlesource.com/pdfium/+/303e525325904cd9b6a847f48951510e7dd8a45e

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+232 lines, -966 lines) Patch
M BUILD.gn View 1 chunk +1 line, -2 lines 0 comments Download
M core/fxcrt/include/fx_stream.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa.gyp View 1 chunk +1 line, -2 lines 0 comments Download
M xfa/fgas/font/fgas_font.h View 4 chunks +4 lines, -19 lines 0 comments Download
M xfa/fgas/font/fgas_gefont.h View 3 chunks +4 lines, -2 lines 0 comments Download
M xfa/fgas/font/fgas_gefont.cpp View 1 1 chunk +1 line, -0 lines 0 comments Download
M xfa/fgas/font/fgas_stdfontmgr.h View 3 chunks +10 lines, -6 lines 0 comments Download
M xfa/fgas/font/fgas_stdfontmgr.cpp View 1 1 chunk +9 lines, -11 lines 0 comments Download
M xfa/fgas/xml/fgas_sax.h View 1 chunk +127 lines, -32 lines 0 comments Download
A + xfa/fgas/xml/fgas_sax.cpp View 1 5 chunks +21 lines, -21 lines 0 comments Download
D xfa/fgas/xml/fgas_sax_imp.h View 1 chunk +0 lines, -141 lines 0 comments Download
D xfa/fgas/xml/fgas_sax_imp.cpp View 1 1 chunk +0 lines, -688 lines 0 comments Download
M xfa/fwl/theme/cfwl_widgettp.h View 2 chunks +2 lines, -2 lines 0 comments Download
M xfa/fwl/theme/cfwl_widgettp.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M xfa/fxfa/app/xfa_checksum.cpp View 1 2 chunks +10 lines, -11 lines 0 comments Download
M xfa/fxfa/app/xfa_ffapp.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M xfa/fxfa/app/xfa_fontmgr.cpp View 1 4 chunks +7 lines, -1 line 0 comments Download
M xfa/fxfa/include/xfa_checksum.h View 1 3 chunks +27 lines, -23 lines 0 comments Download
M xfa/fxfa/include/xfa_ffapp.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/include/xfa_fontmgr.h View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
dsinclair
PTAL.
4 years, 7 months ago (2016-04-27 15:23:17 UTC) #2
Lei Zhang
lgtm https://codereview.chromium.org/1930533002/diff/1/xfa/fgas/xml/fgas_sax.cpp File xfa/fgas/xml/fgas_sax.cpp (right): https://codereview.chromium.org/1930533002/diff/1/xfa/fgas/xml/fgas_sax.cpp#newcode661 xfa/fgas/xml/fgas_sax.cpp:661: FXSYS_assert(m_pHandler); Delete? If the assertion fails, this will ...
4 years, 7 months ago (2016-04-27 19:23:50 UTC) #3
dsinclair
https://codereview.chromium.org/1930533002/diff/1/xfa/fgas/xml/fgas_sax.cpp File xfa/fgas/xml/fgas_sax.cpp (right): https://codereview.chromium.org/1930533002/diff/1/xfa/fgas/xml/fgas_sax.cpp#newcode661 xfa/fgas/xml/fgas_sax.cpp:661: FXSYS_assert(m_pHandler); On 2016/04/27 19:23:49, Lei Zhang wrote: > Delete? ...
4 years, 7 months ago (2016-04-27 19:31:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1930533002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1930533002/20001
4 years, 7 months ago (2016-04-27 19:31:44 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-04-27 19:47:05 UTC) #9
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/303e525325904cd9b6a847f48951510e7dd8...

Powered by Google App Engine
This is Rietveld 408576698