Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issue 193053002: Tweaks and fixes to the SMILTimeContainer frame scheduling logic (Closed)

Created:
6 years, 9 months ago by fs
Modified:
6 years, 9 months ago
CC:
blink-reviews, ed+blinkwatch_opera.com, shans, rjwright, alancutter (OOO until 2018), Mike Lawther (Google), rwlbuis, kouhei+svg_chromium.org, dstockwell, Timothy Loh, krit, f(malita), gyuyoung.kim_webkit.org, darktears, Stephen Chennney, Steve Block, dino_apple.com, Eric Willigers
Visibility:
Public.

Description

Tweaks and fixes to the SMILTimeContainer frame scheduling logic Restore the old frame delay as |initialFrameDelay| and use that in begin(). (There's a 15ms difference from DocumentTimeline::s_minimumDelay, in case that matters to some layout test.) Use a separate state (FutureAnimationFrame) for the cases where an animation frame is requested later than the next frame interval. This avoids unnecessary work in the frame callback (which is gated on the state being AnimationFrame). Fix an issue where an animation frame could end up being scheduled, although a synchronization had been triggered already (via updateAnimations() and a syncbase dependency for instance). Similarly also avoid increasing the timer in begin() for similar cases. BUG=231576 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169259

Patch Set 1 #

Patch Set 2 : FROM_HERE. #

Patch Set 3 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -9 lines) Patch
M Source/core/svg/animation/SMILTimeContainer.h View 2 chunks +3 lines, -0 lines 0 comments Download
M Source/core/svg/animation/SMILTimeContainer.cpp View 1 2 7 chunks +26 lines, -9 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
fs
Iteration on https://codereview.chromium.org/190963003/ - PTAL
6 years, 9 months ago (2014-03-10 18:07:07 UTC) #1
pdr.
On 2014/03/10 18:07:07, fs wrote: > Iteration on https://codereview.chromium.org/190963003/ - PTAL Sorry about the long ...
6 years, 9 months ago (2014-03-13 06:47:56 UTC) #2
fs
On 2014/03/13 06:47:56, pdr wrote: > On 2014/03/10 18:07:07, fs wrote: > > Iteration on ...
6 years, 9 months ago (2014-03-13 09:54:57 UTC) #3
pdr.
On 2014/03/13 09:54:57, fs wrote: > On 2014/03/13 06:47:56, pdr wrote: > > On 2014/03/10 ...
6 years, 9 months ago (2014-03-13 18:33:22 UTC) #4
pdr.
The CQ bit was checked by pdr@chromium.org
6 years, 9 months ago (2014-03-13 18:33:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fs@opera.com/193053002/20001
6 years, 9 months ago (2014-03-13 18:33:31 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-13 18:33:53 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on blink_presubmit tryserver.blink on linux_blink_rel
6 years, 9 months ago (2014-03-13 18:33:54 UTC) #8
fs
The CQ bit was checked by fs@opera.com
6 years, 9 months ago (2014-03-14 16:10:46 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fs@opera.com/193053002/40001
6 years, 9 months ago (2014-03-14 16:10:47 UTC) #10
commit-bot: I haz the power
6 years, 9 months ago (2014-03-14 16:11:16 UTC) #11
Message was sent while issue was closed.
Change committed as 169259

Powered by Google App Engine
This is Rietveld 408576698