Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Issue 1930483002: Mark serviceworker-echo-referrer-from-default-document.html as crashing on Mac. (Closed)

Created:
4 years, 7 months ago by engedy
Modified:
4 years, 7 months ago
Reviewers:
yhirano
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mark serviceworker-echo-referrer-from-default-document.html as crashing on Mac. Add test expectation that http/tests/fetch/referrer/serviceworker-echo-referrer-from-default-document.html will crash on Mac10.11 dbg. BUG=607156 TBR=yhirano Committed: https://crrev.com/68f484f87bf4240e271a9ff96f17f57b7a7de5f3 Cr-Commit-Position: refs/heads/master@{#390067}

Patch Set 1 #

Patch Set 2 : Mark flaky instead. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1930483002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1930483002/1
4 years, 7 months ago (2016-04-27 13:21:35 UTC) #4
yhirano
lgtm, thanks. I'll look into the problem tomorrow.
4 years, 7 months ago (2016-04-27 13:24:10 UTC) #5
engedy
On 2016/04/27 13:24:10, yhirano wrote: > lgtm, thanks. I'll look into the problem tomorrow. SGTM, ...
4 years, 7 months ago (2016-04-27 13:25:59 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1930483002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1930483002/20001
4 years, 7 months ago (2016-04-27 13:26:55 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-04-27 14:32:57 UTC) #12
commit-bot: I haz the power
4 years, 7 months ago (2016-04-27 14:35:24 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/68f484f87bf4240e271a9ff96f17f57b7a7de5f3
Cr-Commit-Position: refs/heads/master@{#390067}

Powered by Google App Engine
This is Rietveld 408576698