Adding support for Win+L key combo in Windows host.

remoting/host/desktop_process.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // This file implements the Windows service controlling Me2Me host processes
 // running within user sessions.
 
 #include "remoting/host/desktop_process.h"
 
 #include <utility>
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/debug/alias.h"
 #include "base/logging.h"
 #include "base/memory/ref_counted.h"
 #include "base/message_loop/message_loop.h"
 #include "base/strings/string_util.h"
+#include "base/win/windows_version.h"

[Jamie, 2016/04/29 00:41:42]

Does this also need an ifdef?

[joedow, 2016/04/29 16:13:09]

Done.

 #include "build/build_config.h"
 #include "ipc/attachment_broker_unprivileged.h"
 #include "ipc/ipc_channel_proxy.h"
 #include "remoting/base/auto_thread.h"
 #include "remoting/base/auto_thread_task_runner.h"
 #include "remoting/host/chromoting_messages.h"
 #include "remoting/host/desktop_environment.h"
 #include "remoting/host/desktop_session_agent.h"
 
 namespace remoting {
@@ skipping 25 matching lines @@
 
   OnChannelError();
 }
 
 void DesktopProcess::InjectSas() {
   DCHECK(caller_task_runner_->BelongsToCurrentThread());
 
   daemon_channel_->Send(new ChromotingDesktopDaemonMsg_InjectSas());
 }
 
+void DesktopProcess::LockWorkStation() {
+  DCHECK(caller_task_runner_->BelongsToCurrentThread());
+#if defined(OS_WIN)
+  if (base::win::OSInfo::GetInstance()->version_type() ==
+      base::win::VersionType::SUITE_HOME) {
+    return;
+  }
+
+  if (!::LockWorkStation()) {
+    LOG(ERROR) << "LockWorkStation() failed: " << ::GetLastError();
+  }
+#else
+  NOTIMPLEMENTED();

[Jamie, 2016/04/29 00:41:42]

Maybe NOTREACHED would be more appropriate here?

[joedow, 2016/04/29 16:13:09]

Done.

+#endif  // defined(OS_WIN)
+}

[Jamie, 2016/04/28 22:00:11]

I think this needs to factored out more cleanly into a Windows-specific location
(for example, I'm not sure that the new #include will work on other platforms).
In general, platform-specific ifdefs should be a last resort.

One option would be to have a generic shortcut-handler interface that could be
registered for platform-specific keyboard combinations. Windows could then use
that for Ctrl+Alt+Del and Win+L (with the advantage of moving related
functionality closer together). Other platforms could simply not register a
handler.

WDYT?

[joedow, 2016/04/29 16:13:09]

Acknowledged.

+
 bool DesktopProcess::OnMessageReceived(const IPC::Message& message) {
   DCHECK(caller_task_runner_->BelongsToCurrentThread());
 
   bool handled = true;
   IPC_BEGIN_MESSAGE_MAP(DesktopProcess, message)
     IPC_MESSAGE_HANDLER(ChromotingDaemonMsg_Crash, OnCrash)
     IPC_MESSAGE_UNHANDLED(handled = false)
   IPC_END_MESSAGE_MAP()
 
   CHECK(handled) << "Received unexpected IPC type: " << message.type();
@@ skipping 87 matching lines @@
   base::snprintf(message, sizeof(message),
                  "Requested by %s at %s, line %d.",
                  function_name.c_str(), file_name.c_str(), line_number);
   base::debug::Alias(message);
 
   // The daemon requested us to crash the process.
   CHECK(false) << message;
 }
 
 } // namespace remoting