Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issue 1930423002: Require Android SDK copy of CMake to build Vulkan on Android. (Closed)

Created:
4 years, 7 months ago by djsollen
Modified:
4 years, 7 months ago
Reviewers:
egdaniel, liyuqian
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -7 lines) Patch
M DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M platform_tools/android/bin/android_setup.sh View 1 2 chunks +11 lines, -4 lines 0 comments Download
M tools/build_shaderc.py View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
djsollen
4 years, 7 months ago (2016-04-29 14:47:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1930423002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1930423002/20001
4 years, 7 months ago (2016-04-29 14:53:19 UTC) #5
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
4 years, 7 months ago (2016-04-29 14:53:20 UTC) #6
egdaniel
lgtm
4 years, 7 months ago (2016-04-29 14:55:45 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-04-29 15:09:47 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/affacce4c6d4eb875819392de8308e191476c8f9

Powered by Google App Engine
This is Rietveld 408576698