chrome/app/BUILD.gn - Issue 1930403003: [Mac/GN] Get chrome and chrome_framework building.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/app/BUILD.gn

Issue 1930403003: [Mac/GN] Get chrome and chrome_framework building. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@gn-chrome-app-shim

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/app/BUILD.gn

diff --git a/chrome/app/BUILD.gn b/chrome/app/BUILD.gn

index 76048f73839059bb2523e7abff80c6408e5de37e..8cfd93049aa0d62c7122468c95723579888f2a39 100644

--- a/chrome/app/BUILD.gn

+++ b/chrome/app/BUILD.gn

@@ -340,7 +340,7 @@ source_set("test_support") {

if (is_mac) {

sources += [ "chrome_main_mac.mm" ]

- deps += [ "//chrome:main_dll" ]

+ deps += [ "//chrome:chrome_framework" ]

}

if (is_win) {

« build/util/branding.gni ('K') | « chrome/BUILD.gn ('k') | chrome/chrome_repack_locales.gni » ('j') | no next file with comments »