[Mac/GN] Get chrome and chrome_framework building.

[Mac/GN] Get chrome and chrome_framework building.

This only does an un-branded Chromium build in the static library configuration.

BUG=431177
Committed: https://crrev.com/e8b24a9c1528052fc510b17945822c906187b72d
Cr-Commit-Position: refs/heads/master@{#391226}

[Robert Sesek, 2016-04-29 16:45:53]

https://codereview.chromium.org/1930403003/diff/1/build/util/branding.gni
File build/util/branding.gni (right):

https://codereview.chromium.org/1930403003/diff/1/build/util/branding.gni#new...
build/util/branding.gni:7: # PREFER NOT TO USE THESE. The GYP build uses this
kind of thing extensively.
I know this is not ideal, but the bundle packaging needs these values at
build-time to choose output names.

An alternative would be to have a .gni file that declares
chrome_product_full_name as a string instead.

Depending on your opinion, I will either add the values here (mac_bundle_id and
mac_creator)
https://code.google.com/p/chromium/codesearch#chromium/src/build/chrome_setti...
into BRANDING or into the aforementioned gni file.

[Robert Sesek, 2016-04-29 16:46:13]

rsesek@chromium.org changed reviewers:
+ brettw@chromium.org

[Robert Sesek, 2016-05-02 17:00:43]

rsesek@chromium.org changed reviewers:
+ mark@chromium.org

[Robert Sesek, 2016-05-02 17:00:44]

+mark for review

[Mark Mentovai, 2016-05-02 17:06:10]

LGTM

[brettw, 2016-05-02 18:01:32]

rs lgtm

[Robert Sesek, 2016-05-02 22:36:45]

On 2016/05/02 18:01:32, brettw wrote:
> rs lgtm

Thanks, just want to make sure you saw this comment:
https://codereview.chromium.org/1930403003/diff/1/build/util/branding.gni#new...

[brettw, 2016-05-02 22:46:39]

I saw the comment. Normally I would say we should avoid exec_script at all costs
and use build args more, but it seems like this is a set of things that are
supposed to stay in sync.

[brettw, 2016-05-02 22:47:14]

(thanks for checking)

[Robert Sesek, 2016-05-03 13:48:21]

The CQ bit was checked by rsesek@chromium.org

[Robert Sesek, 2016-05-03 13:48:22]

The patchset sent to the CQ was uploaded after l-g-t-m from mark@chromium.org,
brettw@chromium.org
Link to the patchset: https://codereview.chromium.org/1930403003/#ps20001
(title: "Rebase")

[commit-bot: I haz the power, 2016-05-03 13:48:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1930403003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1930403003/20001

[commit-bot: I haz the power, 2016-05-03 14:30:02]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-05-03 14:31:39]

Description was changed from

==========
[Mac/GN] Get chrome and chrome_framework building.

This only does an un-branded Chromium build in the static library configuration.

BUG=431177
==========

to

==========
[Mac/GN] Get chrome and chrome_framework building.

This only does an un-branded Chromium build in the static library configuration.

BUG=431177

Committed: https://crrev.com/e8b24a9c1528052fc510b17945822c906187b72d
Cr-Commit-Position: refs/heads/master@{#391226}
==========

[commit-bot: I haz the power, 2016-05-03 14:31:41]

Patchset 2 (id:??) landed as
https://crrev.com/e8b24a9c1528052fc510b17945822c906187b72d
Cr-Commit-Position: refs/heads/master@{#391226}