Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Side by Side Diff: chrome/browser/cocoa/edit_search_engine_cocoa_controller_unittest.mm

Issue 193040: [Mac] Implement the search engine manager (Closed)
Patch Set: Final patch Created 11 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "app/l10n_util_mac.h"
6 #include "base/scoped_nsobject.h"
7 #include "chrome/browser/browser.h"
8 #include "chrome/browser/cocoa/browser_test_helper.h"
9 #include "chrome/browser/cocoa/cocoa_test_helper.h"
10 #import "chrome/browser/cocoa/edit_search_engine_cocoa_controller.h"
11 #include "chrome/test/testing_profile.h"
12 #include "grit/generated_resources.h"
13 #include "testing/gtest/include/gtest/gtest.h"
14 #include "testing/platform_test.h"
15
16 @interface FakeEditSearchEngineController : EditSearchEngineCocoaController {
17 }
18 @property (readonly) NSTextField* nameField;
19 @property (readonly) NSTextField* keywordField;
20 @property (readonly) NSTextField* urlField;
21 @property (readonly) NSImageView* nameImage;
22 @property (readonly) NSImageView* keywordImage;
23 @property (readonly) NSImageView* urlImage;
24 @property (readonly) NSButton* doneButton;
25 @property (readonly) NSImage* goodImage;
26 @property (readonly) NSImage* badImage;
27 @end
28
29 @implementation FakeEditSearchEngineController
30 @synthesize nameField = nameField_;
31 @synthesize keywordField = keywordField_;
32 @synthesize urlField = urlField_;
33 @synthesize nameImage = nameImage_;
34 @synthesize keywordImage = keywordImage_;
35 @synthesize urlImage = urlImage_;
36 @synthesize doneButton = doneButton_;
37 - (NSImage*)goodImage {
38 return goodImage_.get();
39 }
40 - (NSImage*)badImage {
41 return badImage_.get();
42 }
43 @end
44
45 namespace {
46
47 class EditSearchEngineControllerTest : public PlatformTest {
48 public:
49 void SetUp() {
50 TestingProfile* profile =
51 static_cast<TestingProfile*>(browser_helper_.profile());
52 profile->CreateTemplateURLModel();
53 controller_.reset([[FakeEditSearchEngineController alloc]
54 initWithProfile:profile
55 delegate:nil
56 templateURL:nil]);
57 }
58
59 CocoaTestHelper cocoa_helper_;
60 BrowserTestHelper browser_helper_;
61 scoped_nsobject<FakeEditSearchEngineController> controller_;
62 };
63
64 TEST_F(EditSearchEngineControllerTest, ValidImageOriginals) {
65 EXPECT_FALSE([controller_ goodImage]);
66 EXPECT_FALSE([controller_ badImage]);
67
68 EXPECT_TRUE([controller_ window]); // Force the window to load.
69
70 EXPECT_TRUE([[controller_ goodImage] isKindOfClass:[NSImage class]]);
71 EXPECT_TRUE([[controller_ badImage] isKindOfClass:[NSImage class]]);
72
73 // Test window title is set correctly.
74 NSString* title = l10n_util::GetNSString(
75 IDS_SEARCH_ENGINES_EDITOR_NEW_WINDOW_TITLE);
76 EXPECT_TRUE([title isEqualToString:[[controller_ window] title]]);
77 }
78
79 TEST_F(EditSearchEngineControllerTest, SetImageViews) {
80 EXPECT_TRUE([controller_ window]); // Force the window to load.
81 EXPECT_EQ([controller_ badImage], [[controller_ nameImage] image]);
82 // An empty keyword is OK.
83 EXPECT_EQ([controller_ goodImage], [[controller_ keywordImage] image]);
84 EXPECT_EQ([controller_ badImage], [[controller_ urlImage] image]);
85 }
86
87 // This test ensures that on creating a new keyword, we are in an "invalid"
88 // state that cannot save.
89 TEST_F(EditSearchEngineControllerTest, InvalidState) {
90 EXPECT_TRUE([controller_ window]); // Force window to load.
91 NSString* toolTip = nil;
92 EXPECT_FALSE([controller_ validateFields]);
93
94 EXPECT_TRUE([@"" isEqualToString:[[controller_ nameField] stringValue]]);
95 EXPECT_EQ([controller_ badImage], [[controller_ nameImage] image]);
96 toolTip = l10n_util::GetNSString(IDS_SEARCH_ENGINES_INVALID_TITLE_TT);
97 EXPECT_TRUE([toolTip isEqualToString:[[controller_ nameField] toolTip]]);
98 EXPECT_TRUE([toolTip isEqualToString:[[controller_ nameImage] toolTip]]);
99
100 // Keywords can be empty strings.
101 EXPECT_TRUE([@"" isEqualToString:[[controller_ keywordField] stringValue]]);
102 EXPECT_EQ([controller_ goodImage], [[controller_ keywordImage] image]);
103 EXPECT_FALSE([[controller_ keywordField] toolTip]);
104 EXPECT_FALSE([[controller_ keywordImage] toolTip]);
105
106 EXPECT_TRUE([@"" isEqualToString:[[controller_ urlField] stringValue]]);
107 EXPECT_EQ([controller_ badImage], [[controller_ urlImage] image]);
108 toolTip = l10n_util::GetNSString(IDS_SEARCH_ENGINES_INVALID_URL_TT);
109 EXPECT_TRUE([toolTip isEqualToString:[[controller_ urlField] toolTip]]);
110 EXPECT_TRUE([toolTip isEqualToString:[[controller_ urlImage] toolTip]]);
111 }
112
113 // Tests that the single name field validates.
114 TEST_F(EditSearchEngineControllerTest, ValidateName) {
115 EXPECT_TRUE([controller_ window]); // Force window to load.
116
117 EXPECT_EQ([controller_ badImage], [[controller_ nameImage] image]);
118 EXPECT_FALSE([controller_ validateFields]);
119 NSString* toolTip =
120 l10n_util::GetNSString(IDS_SEARCH_ENGINES_INVALID_TITLE_TT);
121 EXPECT_TRUE([toolTip isEqualToString:[[controller_ nameField] toolTip]]);
122 EXPECT_TRUE([toolTip isEqualToString:[[controller_ nameImage] toolTip]]);
123 [[controller_ nameField] setStringValue:@"Test Name"];
124 EXPECT_FALSE([controller_ validateFields]);
125 EXPECT_EQ([controller_ goodImage], [[controller_ nameImage] image]);
126 EXPECT_FALSE([[controller_ nameField] toolTip]);
127 EXPECT_FALSE([[controller_ nameImage] toolTip]);
128 EXPECT_FALSE([[controller_ doneButton] isEnabled]);
129 }
130
131 // The keyword field is valid even if empty.
132 TEST_F(EditSearchEngineControllerTest, ValidateKeyword) {
133 EXPECT_TRUE([controller_ window]); // Force window load.
134
135 EXPECT_EQ([controller_ goodImage], [[controller_ keywordImage] image]);
136 EXPECT_FALSE([controller_ validateFields]);
137 EXPECT_FALSE([[controller_ keywordField] toolTip]);
138 EXPECT_FALSE([[controller_ keywordImage] toolTip]);
139 [[controller_ keywordField] setStringValue:@"foobar"];
140 EXPECT_FALSE([controller_ validateFields]);
141 EXPECT_EQ([controller_ goodImage], [[controller_ keywordImage] image]);
142 EXPECT_FALSE([[controller_ keywordField] toolTip]);
143 EXPECT_FALSE([[controller_ keywordImage] toolTip]);
144 EXPECT_FALSE([[controller_ doneButton] isEnabled]);
145 }
146
147 // Tests that the URL field validates.
148 TEST_F(EditSearchEngineControllerTest, ValidateURL) {
149 EXPECT_TRUE([controller_ window]); // Force window to load.
150
151 EXPECT_EQ([controller_ badImage], [[controller_ urlImage] image]);
152 EXPECT_FALSE([controller_ validateFields]);
153 NSString* toolTip =
154 l10n_util::GetNSString(IDS_SEARCH_ENGINES_INVALID_URL_TT);
155 EXPECT_TRUE([toolTip isEqualToString:[[controller_ urlField] toolTip]]);
156 EXPECT_TRUE([toolTip isEqualToString:[[controller_ urlImage] toolTip]]);
157 [[controller_ urlField] setStringValue:@"http://foo-bar.com"];
158 EXPECT_FALSE([controller_ validateFields]);
159 EXPECT_EQ([controller_ goodImage], [[controller_ urlImage] image]);
160 EXPECT_FALSE([[controller_ urlField] toolTip]);
161 EXPECT_FALSE([[controller_ urlImage] toolTip]);
162 EXPECT_FALSE([[controller_ doneButton] isEnabled]);
163 }
164
165 // Tests that if the user enters all valid data that the UI reflects that
166 // and that they can save.
167 TEST_F(EditSearchEngineControllerTest, ValidateFields) {
168 EXPECT_TRUE([controller_ window]); // Force window to load.
169
170 // State before entering data.
171 EXPECT_EQ([controller_ badImage], [[controller_ nameImage] image]);
172 EXPECT_EQ([controller_ goodImage], [[controller_ keywordImage] image]);
173 EXPECT_EQ([controller_ badImage], [[controller_ urlImage] image]);
174 EXPECT_FALSE([[controller_ doneButton] isEnabled]);
175 EXPECT_FALSE([controller_ validateFields]);
176
177 [[controller_ nameField] setStringValue:@"Test Name"];
178 EXPECT_FALSE([controller_ validateFields]);
179 EXPECT_EQ([controller_ goodImage], [[controller_ nameImage] image]);
180 EXPECT_FALSE([[controller_ doneButton] isEnabled]);
181
182 [[controller_ keywordField] setStringValue:@"foobar"];
183 EXPECT_FALSE([controller_ validateFields]);
184 EXPECT_EQ([controller_ goodImage], [[controller_ keywordImage] image]);
185 EXPECT_FALSE([[controller_ doneButton] isEnabled]);
186
187 // Once the URL is entered, we should have all 3 valid fields.
188 [[controller_ urlField] setStringValue:@"http://foo-bar.com"];
189 EXPECT_TRUE([controller_ validateFields]);
190 EXPECT_EQ([controller_ goodImage], [[controller_ urlImage] image]);
191 EXPECT_TRUE([[controller_ doneButton] isEnabled]);
192 }
193
194 // Tests editing an existing TemplateURL.
195 TEST_F(EditSearchEngineControllerTest, EditTemplateURL) {
196 TemplateURL url;
197 url.set_short_name(L"Foobar");
198 url.set_keyword(L"keyword");
199 std::wstring urlString = TemplateURLRef::DisplayURLToURLRef(
200 L"http://foo-bar.com");
201 url.SetURL(urlString, 0, 1);
202 controller_.reset([[FakeEditSearchEngineController alloc]
203 initWithProfile:browser_helper_.profile()
204 delegate:nil
205 templateURL:&url]);
206 EXPECT_TRUE([controller_ window]);
207 NSString* title = l10n_util::GetNSString(
208 IDS_SEARCH_ENGINES_EDITOR_EDIT_WINDOW_TITLE);
209 EXPECT_TRUE([title isEqualToString:[[controller_ window] title]]);
210 NSString* nameString = [[controller_ nameField] stringValue];
211 EXPECT_TRUE([@"Foobar" isEqualToString:nameString]);
212 NSString* keywordString = [[controller_ keywordField] stringValue];
213 EXPECT_TRUE([@"keyword" isEqualToString:keywordString]);
214 NSString* urlValueString = [[controller_ urlField] stringValue];
215 EXPECT_TRUE([@"http://foo-bar.com" isEqualToString:urlValueString]);
216 EXPECT_TRUE([controller_ validateFields]);
217 }
218
219 } // namespace
OLDNEW
« no previous file with comments | « chrome/browser/cocoa/edit_search_engine_cocoa_controller.mm ('k') | chrome/browser/cocoa/keyword_editor_cocoa_controller.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698