Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(741)

Unified Diff: content/browser/media/audio_output_stream_impl.h

Issue 1930393002: Switch stream creation and closing in Chrome audio rendering from IPC to Mojo (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase + tests in progress Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/media/audio_output_stream_impl.h
diff --git a/content/browser/media/audio_output_stream_impl.h b/content/browser/media/audio_output_stream_impl.h
new file mode 100644
index 0000000000000000000000000000000000000000..53bab9b6e43b5ac3a82b179deb3f63c24f100bf6
--- /dev/null
+++ b/content/browser/media/audio_output_stream_impl.h
@@ -0,0 +1,63 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CONTENT_BROWSER_MEDIA_AUDIO_OUTPUT_STREAM_IMPL_H_
+#define CONTENT_BROWSER_MEDIA_AUDIO_OUTPUT_STREAM_IMPL_H_
+
+#include "base/callback.h"
+#include "content/browser/media/audio_output_impl.h"
+#include "content/browser/renderer_host/media/audio_renderer_host.h"
+#include "content/common/content_export.h"
+#include "media/mojo/interfaces/audio_output.mojom.h"
+#include "mojo/public/cpp/bindings/interface_request.h"
+#include "mojo/public/cpp/bindings/strong_binding.h"
+
+namespace content {
+
+// This class implements AudioOutputStream Mojo interface. It will be used
+// by the AudioOutputClient to perform operations on audio output streams.
+// AudioOutputClient will perform operations remotely on the
+// AudioOutputStreamPtr and Mojo will transfer them to AudioOutputStreamImpl.
+// Owned by AudioOutputImpl.
+class CONTENT_EXPORT AudioOutputStreamImpl
+ : public media::mojom::AudioOutputStream {
+ public:
+ AudioOutputStreamImpl(media::mojom::AudioOutputStreamRequest request,
+ int stream_id,
+ int renderer_frame_id,
+ AudioRendererHost* audio_renderer_host);
+
+ ~AudioOutputStreamImpl() override;
+
+ int get_stream_id() const { return stream_id_; }
+
+ private:
+ FRIEND_TEST_ALL_PREFIXES(AudioOutputStreamImplTest, Close);
+ // AudioOutputStream interface implementation.
+ void Close() override;
+
+ mojo::Binding<media::mojom::AudioOutputStream> binding_;
+ int stream_id_;
+ int renderer_frame_id_;
+ // AudioRendererHost is ref counted and AudioOutputImpl holds a reference to
+ // it. And because all AudioOutputStreamImpl instances will be owned by
+ // AudioOutputImpl too, it's safe to access AudioRendererHost from
+ // AudioOutputStreamImpl.
+ // The only issue that could happen is during AudioOutputStreamImpl
+ // destructor. AudioRendererHost cannot access from there.
+ AudioRendererHost* audio_renderer_host_;
+};
+
+class CONTENT_EXPORT AudioOutputStreamFactory {
+ public:
+ static AudioOutputStreamImpl* Factory(
+ media::mojom::AudioOutputStreamRequest request,
+ int stream_id,
+ int renderer_frame_id,
+ AudioRendererHost* audio_renderer_host);
+};
+
+} // namespace content
+
+#endif // CONTENT_BROWSER_MEDIA_AUDIO_OUTPUT_STREAM_IMPL_H_

Powered by Google App Engine
This is Rietveld 408576698