Switch stream creation and closing in Chrome audio rendering from IPC to Mojo

content/browser/media/audio_output_stream_impl.h

+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CONTENT_BROWSER_MEDIA_AUDIO_OUTPUT_STREAM_IMPL_H_
+#define CONTENT_BROWSER_MEDIA_AUDIO_OUTPUT_STREAM_IMPL_H_
+
+#include "base/callback.h"
+#include "content/browser/media/audio_output_impl.h"
+#include "content/browser/renderer_host/media/audio_renderer_host.h"
+#include "content/common/content_export.h"
+#include "media/mojo/interfaces/audio_output.mojom.h"
+#include "mojo/public/cpp/bindings/interface_request.h"
+#include "mojo/public/cpp/bindings/strong_binding.h"
+
+namespace content {
+
+// This class implements AudioOutputStream Mojo interface. It will be used
+// by the AudioOutputClient to perform operations on audio output streams.
+// AudioOutputClient will perform operations remotely on the
+// AudioOutputStreamPtr and Mojo will transfer them to AudioOutputStreamImpl.
+// Owned by AudioOutputImpl.
+class CONTENT_EXPORT AudioOutputStreamImpl
+    : public media::mojom::AudioOutputStream {
+ public:
+  AudioOutputStreamImpl(int stream_id,
+                        int render_frame_id,
+                        AudioOutputImpl* audio_output_impl,
+                        media::mojom::AudioOutputStreamRequest request);
+
+  ~AudioOutputStreamImpl() override;
+
+  int get_stream_id() const { return stream_id_; }

[nasko, 2016/05/25 20:50:42]

No need for a get_ prefix, as the style guide explicitly states that simple
accessors are named the same as the variable name they expose. In this case "int
stream_id() ..."

[rchtara, 2016/05/27 15:24:39]

Done.

+
+ private:
+  FRIEND_TEST_ALL_PREFIXES(AudioOutputStreamImplTest, Close);
+  // AudioOutputStream interface implementation.
+  void Close() override;
+
+  int stream_id_;
+  int render_frame_id_;
+  // AudioRendererHost is ref counted and AudioOutputImpl holds a reference to
+  // it. And because all AudioOutputStreamImpl instances will be owned by
+  // AudioOutputImpl too, it's safe to access AudioRendererHost from
+  // AudioOutputStreamImpl.
+  // The only issue that could happen is during AudioOutputStreamImpl
+  // destructor. AudioRendererHost cannot access from there.
+  AudioOutputImpl* audio_output_impl_;
+  // Callback for media::mojom::AudioOutput::CreateStream.
+  media::mojom::AudioOutput::CreateStreamCallback create_stream_callback_;
+  mojo::Binding<media::mojom::AudioOutputStream> binding_;
+  media::mojom::AudioOutputStreamPtr stream_ptr_;
+};
+
+}  // namespace content
+
+#endif  // CONTENT_BROWSER_MEDIA_AUDIO_OUTPUT_STREAM_IMPL_H_