Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Unified Diff: third_party/WebKit/Source/core/dom/Document.h

Issue 1930363002: Avoid clobbering state in viewport tag initialization. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Code review comments Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/dom/Document.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/dom/Document.h
diff --git a/third_party/WebKit/Source/core/dom/Document.h b/third_party/WebKit/Source/core/dom/Document.h
index f130ef0e2c3852bfb8c4903318299438703f071c..2570663dca17e80217cba97c257e7c135a263328 100644
--- a/third_party/WebKit/Source/core/dom/Document.h
+++ b/third_party/WebKit/Source/core/dom/Document.h
@@ -264,10 +264,10 @@ public:
DEFINE_ATTRIBUTE_EVENT_LISTENER(selectstart);
DEFINE_ATTRIBUTE_EVENT_LISTENER(wheel);
- bool shouldMergeWithLegacyDescription(ViewportDescription::Type);
- bool shouldOverrideLegacyDescription(ViewportDescription::Type);
+ bool shouldMergeWithLegacyDescription(ViewportDescription::Type) const;
+ bool shouldOverrideLegacyDescription(ViewportDescription::Type) const;
void setViewportDescription(const ViewportDescription&);
- const ViewportDescription& viewportDescription() const { return m_viewportDescription; }
+ ViewportDescription viewportDescription() const;
Length viewportDefaultMinWidth() const { return m_viewportDefaultMinWidth; }
String outgoingReferrer() const override;
@@ -1414,7 +1414,7 @@ private:
extern template class CORE_EXTERN_TEMPLATE_EXPORT Supplement<Document>;
-inline bool Document::shouldOverrideLegacyDescription(ViewportDescription::Type origin)
+inline bool Document::shouldOverrideLegacyDescription(ViewportDescription::Type origin) const
{
// The different (legacy) meta tags have different priorities based on the type
// regardless of which order they appear in the DOM. The priority is given by the
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/dom/Document.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698