Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 1930353002: Invoke factories once in MostVisitedSites(). (Closed)

Created:
4 years, 7 months ago by sfiera
Modified:
4 years, 7 months ago
Reviewers:
Marc Treib
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Invoke factories once in MostVisitedSites(). Instances will be injected from outside in the future. For now, initialize them once in the constructor. BUG=603026 Committed: https://crrev.com/728962fd55a559c3ca9ca4004c59abde173367f7 Cr-Commit-Position: refs/heads/master@{#390615}

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -39 lines) Patch
M chrome/browser/android/ntp/most_visited_sites.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/android/ntp/most_visited_sites.cc View 1 2 9 chunks +25 lines, -39 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1930353002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1930353002/1
4 years, 7 months ago (2016-04-29 10:05:47 UTC) #2
sfiera
Tree seems to be broken for gn right now, so I can't test this yet--not ...
4 years, 7 months ago (2016-04-29 10:06:40 UTC) #4
Marc Treib
LGTM, thanks! (The tree seems to be fine..?) https://codereview.chromium.org/1930353002/diff/1/chrome/browser/android/ntp/most_visited_sites.cc File chrome/browser/android/ntp/most_visited_sites.cc (right): https://codereview.chromium.org/1930353002/diff/1/chrome/browser/android/ntp/most_visited_sites.cc#newcode183 chrome/browser/android/ntp/most_visited_sites.cc:183: SuggestionsServiceFactory::GetForProfile(profile_)), ...
4 years, 7 months ago (2016-04-29 10:12:35 UTC) #5
sfiera
https://codereview.chromium.org/1930353002/diff/1/chrome/browser/android/ntp/most_visited_sites.cc File chrome/browser/android/ntp/most_visited_sites.cc (right): https://codereview.chromium.org/1930353002/diff/1/chrome/browser/android/ntp/most_visited_sites.cc#newcode183 chrome/browser/android/ntp/most_visited_sites.cc:183: SuggestionsServiceFactory::GetForProfile(profile_)), On 2016/04/29 10:12:34, Marc Treib wrote: > nit: ...
4 years, 7 months ago (2016-04-29 10:15:33 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1930353002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1930353002/40001
4 years, 7 months ago (2016-04-29 10:30:20 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 7 months ago (2016-04-29 11:04:12 UTC) #10
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:24:56 UTC) #11
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/728962fd55a559c3ca9ca4004c59abde173367f7
Cr-Commit-Position: refs/heads/master@{#390615}

Powered by Google App Engine
This is Rietveld 408576698