Invoke factories once in MostVisitedSites().

Invoke factories once in MostVisitedSites().

Instances will be injected from outside in the future. For now,
initialize them once in the constructor.

BUG=603026
Committed: https://crrev.com/728962fd55a559c3ca9ca4004c59abde173367f7
Cr-Commit-Position: refs/heads/master@{#390615}

[sfiera, 2016-04-29 10:05:42]

The CQ bit was checked by sfiera@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-29 10:05:47]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1930353002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1930353002/1

[sfiera, 2016-04-29 10:06:39]

sfiera@chromium.org changed reviewers:
+ treib@chromium.org

[sfiera, 2016-04-29 10:06:40]

Tree seems to be broken for gn right now, so I can't test this yet--not sure
what the CQ dry run is going to say.

[Marc Treib, 2016-04-29 10:12:35]

LGTM, thanks!

(The tree seems to be fine..?)

https://codereview.chromium.org/1930353002/diff/1/chrome/browser/android/ntp/...
File chrome/browser/android/ntp/most_visited_sites.cc (right):

https://codereview.chromium.org/1930353002/diff/1/chrome/browser/android/ntp/...
chrome/browser/android/ntp/most_visited_sites.cc:183:
SuggestionsServiceFactory::GetForProfile(profile_)),
nit: Doesn't this fit on the previous line?

[sfiera, 2016-04-29 10:15:33]

https://codereview.chromium.org/1930353002/diff/1/chrome/browser/android/ntp/...
File chrome/browser/android/ntp/most_visited_sites.cc (right):

https://codereview.chromium.org/1930353002/diff/1/chrome/browser/android/ntp/...
chrome/browser/android/ntp/most_visited_sites.cc:183:
SuggestionsServiceFactory::GetForProfile(profile_)),
On 2016/04/29 10:12:34, Marc Treib wrote:
> nit: Doesn't this fit on the previous line?

Oh, yes, it does. Silly irrelevant editor thing.

[sfiera, 2016-04-29 10:30:10]

The CQ bit was checked by sfiera@chromium.org

[sfiera, 2016-04-29 10:30:10]

The patchset sent to the CQ was uploaded after l-g-t-m from treib@chromium.org
Link to the patchset: https://codereview.chromium.org/1930353002/#ps40001
(title: " ")

[commit-bot: I haz the power, 2016-04-29 10:30:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1930353002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1930353002/40001

[commit-bot: I haz the power, 2016-04-29 11:04:12]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-04-30 17:24:56]

Patchset 3 (id:??) landed as
https://crrev.com/728962fd55a559c3ca9ca4004c59abde173367f7
Cr-Commit-Position: refs/heads/master@{#390615}

[commit-bot: I haz the power, 2016-04-30 18:00:04]

Description was changed from

==========
Invoke factories once in MostVisitedSites().

Instances will be injected from outside in the future. For now,
initialize them once in the constructor.

BUG=603026
==========

to

==========
Invoke factories once in MostVisitedSites().

Instances will be injected from outside in the future. For now,
initialize them once in the constructor.

BUG=603026

Committed: https://crrev.com/728962fd55a559c3ca9ca4004c59abde173367f7
Cr-Commit-Position: refs/heads/master@{#390615}
==========