Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(473)

Issue 193033003: Make any sort of ligatures, not just common ligatures, use the complex text path. (Closed)

Created:
6 years, 9 months ago by efidler1
Modified:
6 years, 9 months ago
Reviewers:
eae, eseidel
CC:
blink-reviews, jamesr, krit, dsinclair, jbroman, danakj, Rik, Stephen Chennney, pdr., rwlbuis, Dominik Röttsches
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Make any sort of ligatures, not just common ligatures, use the complex text path. We can remove the incorrect hack in the layout test that used common-ligatures, which forces the complex path. BUG=22240 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168944

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -7 lines) Patch
M LayoutTests/fast/text/font-variant-ligatures.html View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/platform/fonts/FontDescription.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/platform/fonts/FontDescription.cpp View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
efidler1
Ok, trybots finally happy. PTAL
6 years, 9 months ago (2014-03-11 14:40:43 UTC) #1
eae
LGTM
6 years, 9 months ago (2014-03-11 18:19:24 UTC) #2
eae
The CQ bit was checked by eae@chromium.org
6 years, 9 months ago (2014-03-11 18:19:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/efidler@blackberry.com/193033003/1
6 years, 9 months ago (2014-03-11 18:19:49 UTC) #4
commit-bot: I haz the power
6 years, 9 months ago (2014-03-11 20:00:27 UTC) #5
Message was sent while issue was closed.
Change committed as 168944

Powered by Google App Engine
This is Rietveld 408576698