instantiate generic tear-offs, fixes #525

instantiate generic tear-offs, fixes #525

R=het@google.com

Committed: https://github.com/dart-lang/dev_compiler/commit/4d27e3f409afaec75a9501eccbe4e52c5ace999f

[Jennifer Messerly, 2016-04-29 22:09:38]

Description was changed from

==========
instantiate generic methods, fixes #525
==========

to

==========
instantiate generic tear-offs, fixes #525
==========

[Jennifer Messerly, 2016-04-29 22:37:15]

jmesserly@google.com changed reviewers:
+ het@google.com, vsm@google.com

[Harry Terkelsen, 2016-04-29 23:04:11]

lgtm!

https://codereview.chromium.org/1930323004/diff/20001/lib/src/compiler/code_g...
File lib/src/compiler/code_generator.dart (right):

https://codereview.chromium.org/1930323004/diff/20001/lib/src/compiler/code_g...
lib/src/compiler/code_generator.dart:2418: return
typeArgs.arguments.map(visitTypeName).toList(growable: false);
why visitTypeName here and _emitTypeName above? Is it just to guard in case
typeArgs contains a null?

https://codereview.chromium.org/1930323004/diff/20001/lib/src/compiler/code_g...
lib/src/compiler/code_generator.dart:3346: JS.Expression _emitAccess(Expression
target, SimpleIdentifier memberId, DartType resultType) {
long line

https://codereview.chromium.org/1930323004/diff/20001/lib/src/compiler/code_g...
lib/src/compiler/code_generator.dart:3389: 
unnecessary blank lines

[Jennifer Messerly, 2016-04-29 23:08:14]

https://codereview.chromium.org/1930323004/diff/20001/lib/src/compiler/code_g...
File lib/src/compiler/code_generator.dart (right):

https://codereview.chromium.org/1930323004/diff/20001/lib/src/compiler/code_g...
lib/src/compiler/code_generator.dart:2418: return
typeArgs.arguments.map(visitTypeName).toList(growable: false);
On 2016/04/29 23:04:11, Harry Terkelsen wrote:
> why visitTypeName here and _emitTypeName above? Is it just to guard in case
> typeArgs contains a null?

_emitTypeName ... probably should be renamed _emitType. It takes a DartType.
visitTypeName takes the AST node.

https://codereview.chromium.org/1930323004/diff/20001/lib/src/compiler/code_g...
lib/src/compiler/code_generator.dart:3346: JS.Expression _emitAccess(Expression
target, SimpleIdentifier memberId, DartType resultType) {
On 2016/04/29 23:04:11, Harry Terkelsen wrote:
> long line

huh, format must've not run, I'll see about that. I think it fixes the blank
line issue too

[Jennifer Messerly, 2016-04-29 23:41:27]

Description was changed from

==========
instantiate generic tear-offs, fixes #525
==========

to

==========
instantiate generic tear-offs, fixes #525

R=het@google.com

Committed:
https://github.com/dart-lang/dev_compiler/commit/4d27e3f409afaec75a9501eccbe4...
==========

[Jennifer Messerly, 2016-04-29 23:41:28]

Committed patchset #3 (id:40001) manually as
4d27e3f409afaec75a9501eccbe4e52c5ace999f (presubmit successful).