Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issue 1930313003: Add a shortcut key to suspend Chrome OS (Closed)

Created:
4 years, 7 months ago by afakhry
Modified:
4 years, 7 months ago
CC:
chromium-reviews, sadrul, yusukes+watch_chromium.org, derat+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, kalyank
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a shortcut key to suspend Chrome OS This CL adds a shortcut key to suspend Chrome OS and updates the keyboard overlay. BUG=357295 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/27fe6b80e735e053baf20744310ed23dd6f7e4f2 Cr-Commit-Position: refs/heads/master@{#391884}

Patch Set 1 #

Total comments: 6

Patch Set 2 : Updating actions.xml. #

Patch Set 3 : derat's comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -0 lines) Patch
M ash/accelerators/accelerator_controller.cc View 4 chunks +11 lines, -0 lines 0 comments Download
M ash/accelerators/accelerator_table.h View 1 chunk +1 line, -0 lines 0 comments Download
M ash/accelerators/accelerator_table.cc View 1 2 5 chunks +7 lines, -0 lines 0 comments Download
M chrome/app/chromeos_strings.grdp View 1 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/keyboard_overlay_data.js View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/keyboard_overlay_ui.cc View 1 chunk +1 line, -0 lines 0 comments Download
M tools/metrics/actions/actions.xml View 1 2 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 22 (8 generated)
afakhry
derat@chromium.org: Please review changes in ash/. xiyuan@chromium.org: Please review changes in keyboard_overlay Thanks!
4 years, 7 months ago (2016-05-04 18:09:11 UTC) #2
xiyuan
lgtm https://codereview.chromium.org/1930313003/diff/1/ash/accelerators/accelerator_controller.cc File ash/accelerators/accelerator_controller.cc (right): https://codereview.chromium.org/1930313003/diff/1/ash/accelerators/accelerator_controller.cc#newcode622 ash/accelerators/accelerator_controller.cc:622: base::RecordAction(UserMetricsAction("Accel_Suspend")); Think we need to update tools/metrics/actions/actions.xml for ...
4 years, 7 months ago (2016-05-04 18:16:52 UTC) #3
afakhry
holte@ for actions.xml. Thanks! https://codereview.chromium.org/1930313003/diff/1/ash/accelerators/accelerator_controller.cc File ash/accelerators/accelerator_controller.cc (right): https://codereview.chromium.org/1930313003/diff/1/ash/accelerators/accelerator_controller.cc#newcode622 ash/accelerators/accelerator_controller.cc:622: base::RecordAction(UserMetricsAction("Accel_Suspend")); On 2016/05/04 18:16:52, xiyuan ...
4 years, 7 months ago (2016-05-04 19:53:23 UTC) #6
Daniel Erat
https://codereview.chromium.org/1930313003/diff/1/ash/accelerators/accelerator_table.cc File ash/accelerators/accelerator_table.cc (right): https://codereview.chromium.org/1930313003/diff/1/ash/accelerators/accelerator_table.cc#newcode368 ash/accelerators/accelerator_table.cc:368: SUSPEND, i'm not convinced that this should be allowed ...
4 years, 7 months ago (2016-05-04 20:26:08 UTC) #7
afakhry
https://codereview.chromium.org/1930313003/diff/1/ash/accelerators/accelerator_table.cc File ash/accelerators/accelerator_table.cc (right): https://codereview.chromium.org/1930313003/diff/1/ash/accelerators/accelerator_table.cc#newcode368 ash/accelerators/accelerator_table.cc:368: SUSPEND, On 2016/05/04 20:26:08, Daniel Erat wrote: > i'm ...
4 years, 7 months ago (2016-05-05 17:34:05 UTC) #8
Daniel Erat
lgtm
4 years, 7 months ago (2016-05-05 17:50:33 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1930313003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1930313003/40001
4 years, 7 months ago (2016-05-05 17:53:43 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/178275)
4 years, 7 months ago (2016-05-05 18:06:02 UTC) #14
afakhry
On 2016/05/05 18:06:02, commit-bot: I haz the power wrote: > Try jobs failed on following ...
4 years, 7 months ago (2016-05-05 18:10:40 UTC) #15
Steven Holte
lgtm
4 years, 7 months ago (2016-05-05 19:48:35 UTC) #16
Steven Holte
lgtm
4 years, 7 months ago (2016-05-05 19:48:36 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1930313003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1930313003/40001
4 years, 7 months ago (2016-05-05 19:57:55 UTC) #19
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 7 months ago (2016-05-05 20:03:50 UTC) #20
commit-bot: I haz the power
4 years, 7 months ago (2016-05-05 20:05:26 UTC) #22
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/27fe6b80e735e053baf20744310ed23dd6f7e4f2
Cr-Commit-Position: refs/heads/master@{#391884}

Powered by Google App Engine
This is Rietveld 408576698