Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 1930303002: Simplify GN target names for //blimp (Closed)

Created:
4 years, 7 months ago by nyquist
Modified:
4 years, 7 months ago
Reviewers:
haibinlu
CC:
chromium-reviews, cbentzel+watch_chromium.org, anandc+watch-blimp_chromium.org, maniscalco+watch-blimp_chromium.org, sriramsr+watch-blimp_chromium.org, nyquist+watch-blimp_chromium.org, marcinjb+watch-blimp_chromium.org, jessicag+watch-blimp_chromium.org, kmarshall+watch-blimp_chromium.org, dtrainor+watch-blimp_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Simplify GN target names for //blimp As part of making the GN configuration for //blimp up to date with current best practices, this CL changes top-level targets under //blimp to have the same name as their folder. As an example, //blimp/common:blimp_common can now be referred to using only //blimp/common. The reason why for example blimp_common was previously chosen was to ensure that the output name of the component did not collide with other targets in the chromium repository. This CL ensures that old output names are kept in place by specifying the output_name GN variable. This is only necessary for build artifacts, and not for gn templates such as group or source_set. BUG=597830 Committed: https://crrev.com/170f32cbc553a61d5dc8f13b7fd173f4c430b432 Cr-Commit-Position: refs/heads/master@{#390682}

Patch Set 1 #

Patch Set 2 : Fix blimp_shell #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -42 lines) Patch
M blimp/BUILD.gn View 2 chunks +3 lines, -3 lines 0 comments Download
M blimp/client/BUILD.gn View 1 8 chunks +15 lines, -15 lines 0 comments Download
M blimp/common/BUILD.gn View 2 chunks +3 lines, -2 lines 0 comments Download
M blimp/docs/container.md View 1 chunk +1 line, -1 line 0 comments Download
M blimp/engine/BUILD.gn View 9 chunks +14 lines, -14 lines 0 comments Download
M blimp/engine/engine-manifest.txt View 2 chunks +2 lines, -2 lines 0 comments Download
M blimp/net/BUILD.gn View 4 chunks +6 lines, -5 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1930303002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1930303002/1
4 years, 7 months ago (2016-04-29 00:55:25 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_clobber_rel_ng/builds/167003)
4 years, 7 months ago (2016-04-29 01:04:30 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1930303002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1930303002/20001
4 years, 7 months ago (2016-04-29 01:08:55 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-04-29 02:12:45 UTC) #8
nyquist
haibinlu: PTAL
4 years, 7 months ago (2016-04-29 16:57:30 UTC) #10
haibinlu
lgtm
4 years, 7 months ago (2016-04-29 17:10:30 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1930303002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1930303002/20001
4 years, 7 months ago (2016-04-29 17:20:57 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-04-29 17:25:42 UTC) #14
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:26:45 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/170f32cbc553a61d5dc8f13b7fd173f4c430b432
Cr-Commit-Position: refs/heads/master@{#390682}

Powered by Google App Engine
This is Rietveld 408576698