Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 1930293002: Revert of Implement arflags in the GN build. (Closed)

Created:
4 years, 7 months ago by bpastene
Modified:
4 years, 7 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Implement arflags in the GN build. (patchset #4 id:60001 of https://codereview.chromium.org/1907403002/ ) Reason for revert: As with the previous attempts to land this cl, android and GPU builders are failing compile with OOM errors: https://bugs.chromium.org/p/chromium/issues/detail?id=607673 Original issue's description: > Implement arflags in the GN build. > > This flag was recently added in GN. This patch hooks it up to the toolchains > and moves some flags to use it that previously had to be hardcoded on the > tool command itself. > > Remove concurrent_links variable from gcc_toolchain which was unused. > > BUG=598599 > Reland of http://crrev.com/1909163002 with no changes (now that a GN binary push to fix the bug has gone in) which was a reland of http://crrev.com/1896163003 with fix. TBR=brucedawson@chromium.org,brettw@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=598599 Committed: https://crrev.com/500a5624ab6d616b503bf75449cfc772b9c3d2c2 Cr-Commit-Position: refs/heads/master@{#390545}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -36 lines) Patch
M build/config/compiler/BUILD.gn View 1 chunk +0 lines, -5 lines 0 comments Download
M build/config/posix/BUILD.gn View 1 chunk +0 lines, -16 lines 0 comments Download
M build/config/win/BUILD.gn View 1 chunk +0 lines, -12 lines 0 comments Download
M build/toolchain/gcc_toolchain.gni View 2 chunks +17 lines, -1 line 0 comments Download
M build/toolchain/mac/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M build/toolchain/win/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
bpastene
Created Revert of Implement arflags in the GN build.
4 years, 7 months ago (2016-04-29 00:33:44 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1930293002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1930293002/1
4 years, 7 months ago (2016-04-29 00:34:57 UTC) #2
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 7 months ago (2016-04-29 00:35:01 UTC) #4
ghost stip (do not use)
lgtm
4 years, 7 months ago (2016-04-29 00:37:38 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1930293002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1930293002/1
4 years, 7 months ago (2016-04-29 00:38:58 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-04-29 00:39:39 UTC) #10
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:22:59 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/500a5624ab6d616b503bf75449cfc772b9c3d2c2
Cr-Commit-Position: refs/heads/master@{#390545}

Powered by Google App Engine
This is Rietveld 408576698