Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(982)

Issue 193026: Merge 25494 - Use system themes where possible in Omnibox edit and dropdown; ... (Closed)

Created:
11 years, 3 months ago by laforge
Modified:
9 years, 7 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews_googlegroups.com, Ben Goodger (Google)
Visibility:
Public.

Description

Merge 25494 - Use system themes where possible in Omnibox edit and dropdown; in other cases, provide a pair of colors and use whichever contrasts more with the relevant background color, to maintain readability. BUG=92, 18367 TEST=Use the omnibox on various nondefault and highcontrast system themes. Observe that everything is always readable. Review URL: http://codereview.chromium.org/200009 TBR=pkasting@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=25508

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+256 lines, -141 lines) Patch
MM chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc View 2 chunks +58 lines, -1 line 0 comments Download
MM chrome/browser/autocomplete/autocomplete_edit_view_win.cc View 7 chunks +20 lines, -26 lines 0 comments Download
MM chrome/browser/toolbar_model.h View 2 chunks +3 lines, -4 lines 0 comments Download
MM chrome/browser/toolbar_model.cc View 3 chunks +2 lines, -10 lines 0 comments Download
MM chrome/browser/views/autocomplete/autocomplete_popup_contents_view.cc View 7 chunks +71 lines, -57 lines 2 comments Download
MM chrome/browser/views/location_bar_view.h View 3 chunks +15 lines, -1 line 0 comments Download
MM chrome/browser/views/location_bar_view.cc View 10 chunks +87 lines, -42 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
laforge
11 years, 3 months ago (2009-09-04 20:44:15 UTC) #1
Peter Kasting
Revert all changes to autocomplete_edit_view_gtk.cc, they're all wrong. http://codereview.chromium.org/193026/diff/1/6 File chrome/browser/views/autocomplete/autocomplete_popup_contents_view.cc (right): http://codereview.chromium.org/193026/diff/1/6#newcode54 Line 54: ...
11 years, 3 months ago (2009-09-04 20:53:58 UTC) #2
Peter Kasting
11 years, 3 months ago (2009-09-04 20:54:03 UTC) #3
Peter Kasting
11 years, 3 months ago (2009-09-04 22:12:30 UTC) #4
http://codereview.chromium.org/193026/diff/1/6
File chrome/browser/views/autocomplete/autocomplete_popup_contents_view.cc
(right):

http://codereview.chromium.org/193026/diff/1/6#newcode423
Line 423: return model_->IsHoveredIndex(model_index_) ? HOVERED : NORMAL;
For 3.0, you should change "model_->IsHoveredIndex(model_index_)" to "hot_".

Powered by Google App Engine
This is Rietveld 408576698