Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(412)

Issue 1930253002: Merge to M51: Accessible name calc should allow aria-labelledby to reference aria-hidden (Closed)

Created:
4 years, 7 months ago by dmazzoni
Modified:
4 years, 7 months ago
Reviewers:
CC:
chromium-reviews, aboxhall, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, haraken, nektarios, je_julie, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2704
Target Ref:
refs/pending/branch-heads/2704
Project:
chromium
Visibility:
Public.

Description

Merge to M51: Accessible name calc should allow aria-labelledby to reference aria-hidden The new accessible name calculation improved compatibility overall but broke one specific case, where one element uses aria-labelledby (or aria-describedby) to reference a subtree that's explicitly aria-hidden. The correct thing to do here is ignore aria-hidden when an element is referenced explicitly. <input aria-labelledby="label"> <div id="label" aria-hidden="true">Hidden label</div> BUG=595494 Review URL: https://codereview.chromium.org/1917943002 Cr-Commit-Position: refs/heads/master@{#389798} (cherry picked from commit 8dacc7a16ffdee2d4af5a60f6f9079c22fd7399c) Committed: https://chromium.googlesource.com/chromium/src/+/6569fe5bbb0fca1b01108549ccbe0916e1d231eb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+105 lines, -2 lines) Patch
A third_party/WebKit/LayoutTests/accessibility/name-calc-aria-hidden.html View 1 chunk +99 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp View 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
dmazzoni
4 years, 7 months ago (2016-04-28 23:07:53 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
6569fe5bbb0fca1b01108549ccbe0916e1d231eb.

Powered by Google App Engine
This is Rietveld 408576698