In prepartion for switching off the activex control, make WMP always use the ...

In prepartion for switching off the activex control, make WMP always use the new UI on XP even if we couldn't update the ShimInclusionList key because of non-admin install.  This change patches RegEnumKey, if needed, so that WMP thinks the key contains chrome.exe

BUG=20259
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=25566

[ananta, 2009-09-04 20:00:40]

http://codereview.chromium.org/193024/diff/1/3
File webkit/glue/plugins/webplugin_delegate_impl_win.cc (right):

http://codereview.chromium.org/193024/diff/1/3#newcode141
Line 141: std::wstring GetKeyPath(HKEY key) {
Should we move this to a lib? There may be a place where we have native API
helpers?

http://codereview.chromium.org/193024/diff/1/3#newcode146
Line 146: HMODULE dll = LoadLibrary(L"ntdll.dll");
ntdll would always be loaded. We can safely use GetModuleHandle here.

http://codereview.chromium.org/193024/diff/1/3#newcode157
Line 157: char* buffer = new char[size];
scoped_ptr?

http://codereview.chromium.org/193024/diff/1/3#newcode1254
Line 1254: HKEY key, DWORD index, LPTSTR name, LPDWORD name_size, LPDWORD
reserved,
LPWSTR?

http://codereview.chromium.org/193024/diff/1/3#newcode1258
Line 1258: class_size, last_write_time);
We should return chrome.exe if RegEnumKeyEx returns an error?

[jam, 2009-09-04 22:25:16]

http://codereview.chromium.org/193024/diff/1/3
File webkit/glue/plugins/webplugin_delegate_impl_win.cc (right):

http://codereview.chromium.org/193024/diff/1/3#newcode141
Line 141: std::wstring GetKeyPath(HKEY key) {
On 2009/09/04 20:00:40, ananta wrote:
> Should we move this to a lib? There may be a place where we have native API
> helpers?

I prefer to leave it in this file unless we need it elsewhere. I don't think
this will be used in other places, as any of our code wouldn't need this since
they would know the path.

http://codereview.chromium.org/193024/diff/1/3#newcode146
Line 146: HMODULE dll = LoadLibrary(L"ntdll.dll");
On 2009/09/04 20:00:40, ananta wrote:
> ntdll would always be loaded. We can safely use GetModuleHandle here.

Done.

http://codereview.chromium.org/193024/diff/1/3#newcode157
Line 157: char* buffer = new char[size];
On 2009/09/04 20:00:40, ananta wrote:
> scoped_ptr?

Done.

http://codereview.chromium.org/193024/diff/1/3#newcode1254
Line 1254: HKEY key, DWORD index, LPTSTR name, LPDWORD name_size, LPDWORD
reserved,
On 2009/09/04 20:00:40, ananta wrote:
> LPWSTR?

Done.

http://codereview.chromium.org/193024/diff/1/3#newcode1258
Line 1258: class_size, last_write_time);
On 2009/09/04 20:00:40, ananta wrote:
> We should return chrome.exe if RegEnumKeyEx returns an error?

Done.

[ananta, 2009-09-04 23:39:10]

LGTM