Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Issue 193023002: rebaseline_server: add actual_repo and actual_revision command line options (Closed)

Created:
6 years, 9 months ago by epoger
Modified:
6 years, 9 months ago
Reviewers:
borenet, bsalomon
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

rebaseline_server: add actual_repo and actual_revision command line options So, if you want to see divergences from expectations as of https://code.google.com/p/skia-autogen/source/detail?r=29365 , specify --actuals-revision 29365 This is also handy for testing rebaseline_server performance improvements against a static set of results. BUG=skia:2248 NOTREECHECKS=True NOTRY=True Committed: http://code.google.com/p/skia/source/detail?r=13726

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -10 lines) Patch
M gm/rebaseline_server/server.py View 8 chunks +28 lines, -7 lines 1 comment Download
M tools/svn.py View 1 chunk +4 lines, -3 lines 2 comments Download

Messages

Total messages: 6 (0 generated)
epoger
Ready for review at patchset 1. First LG wins.
6 years, 9 months ago (2014-03-10 17:38:14 UTC) #1
borenet
Nice! This will allow me to rebaseline flaky GMs even when they didn't fail in ...
6 years, 9 months ago (2014-03-10 18:01:12 UTC) #2
epoger
https://codereview.chromium.org/193023002/diff/1/gm/rebaseline_server/server.py File gm/rebaseline_server/server.py (right): https://codereview.chromium.org/193023002/diff/1/gm/rebaseline_server/server.py#newcode550 gm/rebaseline_server/server.py:550: 'Defaults to %(default)s . Beware of setting this ' ...
6 years, 9 months ago (2014-03-10 18:08:54 UTC) #3
epoger
The CQ bit was checked by epoger@google.com
6 years, 9 months ago (2014-03-10 18:09:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/epoger@google.com/193023002/1
6 years, 9 months ago (2014-03-10 18:09:21 UTC) #5
commit-bot: I haz the power
6 years, 9 months ago (2014-03-10 18:09:28 UTC) #6
Message was sent while issue was closed.
Change committed as 13726

Powered by Google App Engine
This is Rietveld 408576698