Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(2)

Issue 1930213002: [Extensions] More bindings improvements (Closed)

Created:
2 years, 11 months ago by Devlin
Modified:
2 years, 10 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2704
Target Ref:
refs/pending/branch-heads/2704
Project:
chromium
Visibility:
Public.

Description

[Extensions] More bindings improvements Explicitly freeze the schema in chrome, pass safe arguments to GetAvailability, and broaden test access checks. BUG=604901 BUG=603725 BUG=591164 Review URL: https://codereview.chromium.org/1899973002 Cr-Commit-Position: refs/heads/master@{#388353} (cherry picked from commit 585b125ef7168c104631e23ee5cad0108c838f52) Committed: https://chromium.googlesource.com/chromium/src/+/f0f07d08bc3865436994b40aa620d8063fe7bbcc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -4 lines) Patch
M extensions/renderer/module_system_test.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M extensions/renderer/resources/binding.js View 3 chunks +6 lines, -3 lines 0 comments Download
M extensions/renderer/script_context.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/renderer/v8_schema_registry.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
Devlin
Committed patchset #1 (id:1) manually as f0f07d08bc3865436994b40aa620d8063fe7bbcc.
2 years, 10 months ago (2016-04-28 22:29:19 UTC) #2
Devlin
2 years, 10 months ago (2016-04-29 00:32:38 UTC) #3
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1926353002/ by rdevlin.cronin@chromium.org.

The reason for reverting is: Compile fail.

Powered by Google App Engine
This is Rietveld 408576698