Issue 193020: Hung Renderer dialog:...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 193020: Hung Renderer dialog:... (Closed)

Created:
11 years, 3 months ago by TVL

Modified:
9 years, 7 months ago

Reviewers:
Mark Mentovai

CC:
chromium-reviews_googlegroups.com, John Grabowski, pam+watch_chromium.org, Ben Goodger (Google)

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Hung Renderer dialog: Resize to fit the graphic. Fetch the hung from ResourceBundle since it looks like it should be under theme control. Swap the kill and wait buttons. Add in localization objects. Resize message and window to find localized content. Bookmark Bubble: Right align labels to fields. Make window resize to fit labels. Switch to small controls per Cole. Stop bringing the frozen tab graphic into the bundle so we avoid the extra copy. BUG=20525 BUG=20533 TEST=Hung renderer localized and fits content. Bookmark bubble fits labels in all languages. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=25452

Patch Set 1 #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+735 lines, -375 lines)			Patch
M	chrome/app/nibs/BookmarkBubble.xib	View	14 chunks	+453 lines, -266 lines	0 comments	Download
M	chrome/app/nibs/HungRendererDialog.xib	View	19 chunks	+250 lines, -98 lines	0 comments	Download
M	chrome/browser/cocoa/hung_renderer_controller.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/cocoa/hung_renderer_controller.mm	View	4 chunks	+29 lines, -9 lines	0 comments	Download
M	chrome/chrome.gyp	View	2 chunks	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

El Gee

Expand Messages | Collapse Messages