Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 193020: Hung Renderer dialog:... (Closed)

Created:
11 years, 3 months ago by TVL
Modified:
9 years, 7 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews_googlegroups.com, John Grabowski, pam+watch_chromium.org, Ben Goodger (Google)
Visibility:
Public.

Description

Hung Renderer dialog: Resize to fit the graphic. Fetch the hung from ResourceBundle since it looks like it should be under theme control. Swap the kill and wait buttons. Add in localization objects. Resize message and window to find localized content. Bookmark Bubble: Right align labels to fields. Make window resize to fit labels. Switch to small controls per Cole. Stop bringing the frozen tab graphic into the bundle so we avoid the extra copy. BUG=20525 BUG=20533 TEST=Hung renderer localized and fits content. Bookmark bubble fits labels in all languages. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=25452

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+735 lines, -375 lines) Patch
M chrome/app/nibs/BookmarkBubble.xib View 14 chunks +453 lines, -266 lines 0 comments Download
M chrome/app/nibs/HungRendererDialog.xib View 19 chunks +250 lines, -98 lines 0 comments Download
M chrome/browser/cocoa/hung_renderer_controller.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/cocoa/hung_renderer_controller.mm View 4 chunks +29 lines, -9 lines 0 comments Download
M chrome/chrome.gyp View 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
TVL
11 years, 3 months ago (2009-09-04 13:46:54 UTC) #1
Mark Mentovai
11 years, 3 months ago (2009-09-04 13:55:38 UTC) #2
El Gee

Powered by Google App Engine
This is Rietveld 408576698