third_party/WebKit/Source/core/layout/line/InlineBox.h - Issue 1930183002: Refactor scroll updates during flexbox layout.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/line/InlineBox.h

Issue 1930183002: Refactor scroll updates during flexbox layout. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@rtl-scroll-origin

Patch Set: nits Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp ('k') | third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/line/InlineBox.h

diff --git a/third_party/WebKit/Source/core/layout/line/InlineBox.h b/third_party/WebKit/Source/core/layout/line/InlineBox.h

index 56bf5edbf0003431817a48a603f76f2bec057675..559d414fbee50e3aaf2fa072f17ce0d89b870dfb 100644

--- a/third_party/WebKit/Source/core/layout/line/InlineBox.h

+++ b/third_party/WebKit/Source/core/layout/line/InlineBox.h

@@ -288,6 +288,7 @@ public:

// flipped for right-to-left text.

void logicalRectToPhysicalRect(LayoutRect&) const;

+ // TODO(szager): The Rect versions should return a rect, not modify the argument.

void flipForWritingMode(FloatRect&) const;

FloatPoint flipForWritingMode(const FloatPoint&) const;

void flipForWritingMode(LayoutRect&) const;