Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(615)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBlock.h

Issue 1930183002: Refactor scroll updates during flexbox layout. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@rtl-scroll-origin
Patch Set: nits Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/LayoutBlock.h
diff --git a/third_party/WebKit/Source/core/layout/LayoutBlock.h b/third_party/WebKit/Source/core/layout/LayoutBlock.h
index c0cce94a3a5905bc3f61aaccaba821ea51d755f5..59bcd535394114a15d7da63b617dec92f8d1433b 100644
--- a/third_party/WebKit/Source/core/layout/LayoutBlock.h
+++ b/third_party/WebKit/Source/core/layout/LayoutBlock.h
@@ -294,24 +294,6 @@ protected:
bool hitTestChildren(HitTestResult&, const HitTestLocation& locationInContainer, const LayoutPoint& accumulatedOffset, HitTestAction) override;
void updateHitTestResult(HitTestResult&, const LayoutPoint&) override;
- // Delay update scrollbar until finishDelayUpdateScrollInfo() will be
- // called. This function is used when a flexbox is laying out its
- // descendant. If multiple calls are made to startDelayUpdateScrollInfo(),
- // finishDelayUpdateScrollInfo() will do nothing until finishDelayUpdateScrollInfo()
- // is called the same number of times.
- // finishDelayUpdateScrollInfo returns true when it marked something for layout.
- // It will also return a map of saved scroll positions that the caller should restore
- // on the given scrollable areas after performing the layout.
- // This can be necessary because Flexbox's multi-pass layout can lose the scroll position.
- // TODO(cbiesinger): This is a temporary hack. The right solution is to delay the scroll
- // clamping that currently happens in PaintLayerScrollableArea::updateAfterLayout to only
- // happen after all layout is done, i.e. during updateLayerPositionsAfterLayout. However,
- // that currently fails a layout test. To fix this bug in time for M50, we use this temporary
- // hack. The real fix is tracked in crbug.com/600036
- typedef PersistentHeapHashMap<Member<PaintLayerScrollableArea>, DoublePoint> ScrollPositionMap;
- static void startDelayUpdateScrollInfo();
- static bool finishDelayUpdateScrollInfo(SubtreeLayoutScope*, ScrollPositionMap*);
-
void updateAfterLayout();
void styleWillChange(StyleDifference, const ComputedStyle& newStyle) override;

Powered by Google App Engine
This is Rietveld 408576698