Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1930173002: Disable inclusion of x509_certificate_model.h on unsupported platforms. (Closed)

Created:
4 years, 7 months ago by meacer
Modified:
4 years, 7 months ago
Reviewers:
Ryan Sleevi
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable inclusion of x509_certificate_model.h on unsupported platforms. BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M chrome/common/net/x509_certificate_model.h View 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
Ryan Sleevi
Would also have to update the build files. Perfectly OK if you want to file ...
4 years, 7 months ago (2016-04-28 22:09:45 UTC) #2
meacer
4 years, 7 months ago (2016-04-28 22:17:36 UTC) #3 
On 2016/04/28 22:09:45, Ryan Sleevi wrote:
> Would also have to update the build files.

Yes, hence the question about #error or not to #error :)

> Perfectly OK if you want to file a bug on us (Internals>Network>SSL) to own
this
> cleanup, to avoid this confusion where things are only implemented on some
> platforms, but the file is compiled on all (... but doesn't work right)

Ok, I'll do that instead and use the custom serial number printer in the other
CL so as not to go back and forth.

Powered by Google App Engine
This is Rietveld 408576698