Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Unified Diff: BUILD.gn

Issue 1930053002: Add FORCE_64BIT_ALIGN support to BUILD.gn (Closed) Base URL: https://chromium.googlesource.com/chromium/deps/libsrtp.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: BUILD.gn
diff --git a/BUILD.gn b/BUILD.gn
index 1da354e5565474016e3ee592b844570544a16ebd..6f3e0017f9bb198a19bd760978857287d465ca8c 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -67,6 +67,14 @@ config("libsrtp_config") {
# srtp test applications and libjingle.
defines += [ "CPU_CISC" ]
}
+ if (current_cpu == "mipsel" || current_cpu == "arm" || current_cpu == "x86") {
+ # Define FORCE_64BIT_ALIGN to avoid alignment-related-crashes like
+ # crbug/414919. Without this, aes_cbc_alloc will allocate an
+ # aes_cbc_ctx_t not 64-bit aligned and the v128_t members of
+ # aes_cbc_ctx_t will not be 64-bit aligned, which breaks the
+ # compiler optimizations that assume 64-bit alignment of v128_t.
+ defines += [ "FORCE_64BIT_ALIGN" ]
+ }
}
static_library("libsrtp") {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698