Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 1930043002: Add all dart:html tests from the sdk to test/codegen. (Closed)

Created:
4 years, 7 months ago by Jacob
Modified:
4 years, 7 months ago
Reviewers:
vsm
CC:
dev-compiler+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add all dart:html tests from the sdk to test/codegen. All tests are added except for js_array_test.dart and js_dart_to_string_test.dart which have to be stripped out for now due to failures. BUG= R=vsm@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/cfab62eeb528590e402b6f907ecd3ff94cf0c79c

Patch Set 1 #

Total comments: 6

Patch Set 2 : ptal #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18310 lines, -155 lines) Patch
M karma.conf.js View 1 2 chunks +2 lines, -0 lines 0 comments Download
A test/codegen/expect/html_config.js View 1 chunk +11 lines, -0 lines 0 comments Download
A + test/codegen/expect/html_config.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M test/codegen/expect/unittest.js View 4 chunks +96 lines, -2 lines 0 comments Download
A test/codegen/expect/unittest/html_config.js View 1 chunk +11 lines, -0 lines 0 comments Download
A + test/codegen/expect/unittest/html_config.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M test/codegen/expect/unittest/unittest.js View 4 chunks +96 lines, -2 lines 0 comments Download
A + test/codegen/html_config.dart View 1 chunk +3 lines, -12 lines 0 comments Download
A test/codegen/lib/html/Ahem.ttf View Binary file 0 comments Download
A test/codegen/lib/html/async_cancellingisolate.dart View 1 chunk +31 lines, -0 lines 0 comments Download
A test/codegen/lib/html/async_oneshot.dart View 1 chunk +11 lines, -0 lines 0 comments Download
A test/codegen/lib/html/async_periodictimer.dart View 1 chunk +24 lines, -0 lines 0 comments Download
A test/codegen/lib/html/async_spawnuri_test.dart View 1 chunk +37 lines, -0 lines 0 comments Download
A test/codegen/lib/html/async_test.dart View 1 chunk +42 lines, -0 lines 0 comments Download
A test/codegen/lib/html/audiobuffersourcenode_test.dart View 1 chunk +27 lines, -0 lines 0 comments Download
A test/codegen/lib/html/audiocontext_test.dart View 1 chunk +99 lines, -0 lines 0 comments Download
A test/codegen/lib/html/audioelement_test.dart View 1 chunk +28 lines, -0 lines 0 comments Download
A test/codegen/lib/html/b_element_test.dart View 1 chunk +13 lines, -0 lines 0 comments Download
A test/codegen/lib/html/blob_constructor_test.dart View 1 chunk +63 lines, -0 lines 0 comments Download
A test/codegen/lib/html/cache_test.dart View 1 chunk +45 lines, -0 lines 0 comments Download
A test/codegen/lib/html/callbacks_test.dart View 1 chunk +11 lines, -0 lines 0 comments Download
A test/codegen/lib/html/canvas_pixel_array_type_alias_test.dart View 1 chunk +119 lines, -0 lines 0 comments Download
A test/codegen/lib/html/canvas_test.dart View 1 chunk +56 lines, -0 lines 0 comments Download
A test/codegen/lib/html/canvasrenderingcontext2d_test.dart View 1 chunk +740 lines, -0 lines 0 comments Download
A test/codegen/lib/html/cdata_test.dart View 1 chunk +24 lines, -0 lines 0 comments Download
A test/codegen/lib/html/client_rect_test.dart View 1 chunk +30 lines, -0 lines 0 comments Download
A test/codegen/lib/html/cross_domain_iframe_script.html View 1 chunk +14 lines, -0 lines 0 comments Download
A test/codegen/lib/html/cross_domain_iframe_script.js View 1 chunk +1 line, -0 lines 0 comments Download
A test/codegen/lib/html/cross_domain_iframe_test.dart View 1 chunk +29 lines, -0 lines 0 comments Download
A test/codegen/lib/html/cross_frame_test.dart View 1 chunk +75 lines, -0 lines 0 comments Download
A test/codegen/lib/html/crypto_test.dart View 1 chunk +49 lines, -0 lines 0 comments Download
A test/codegen/lib/html/css_rule_list_test.dart View 1 chunk +18 lines, -0 lines 0 comments Download
A test/codegen/lib/html/css_test.dart View 1 chunk +46 lines, -0 lines 0 comments Download
A test/codegen/lib/html/cssstyledeclaration_test.dart View 1 chunk +160 lines, -0 lines 0 comments Download
A test/codegen/lib/html/custom/attribute_changed_callback_test.dart View 1 chunk +128 lines, -0 lines 0 comments Download
A test/codegen/lib/html/custom/attribute_changed_callback_test.html View 1 chunk +22 lines, -0 lines 0 comments Download
A test/codegen/lib/html/custom/constructor_calls_created_synchronously_test.dart View 1 chunk +67 lines, -0 lines 0 comments Download
A test/codegen/lib/html/custom/constructor_calls_created_synchronously_test.html View 1 chunk +22 lines, -0 lines 0 comments Download
A test/codegen/lib/html/custom/created_callback_test.dart View 1 chunk +301 lines, -0 lines 0 comments Download
A test/codegen/lib/html/custom/created_callback_test.html View 1 chunk +22 lines, -0 lines 0 comments Download
A test/codegen/lib/html/custom/document_register_basic_test.dart View 1 chunk +148 lines, -0 lines 0 comments Download
A test/codegen/lib/html/custom/document_register_basic_test.html View 1 chunk +22 lines, -0 lines 0 comments Download
A test/codegen/lib/html/custom/document_register_type_extensions_test.dart View 1 chunk +317 lines, -0 lines 0 comments Download
A test/codegen/lib/html/custom/document_register_type_extensions_test.html View 1 chunk +22 lines, -0 lines 0 comments Download
A test/codegen/lib/html/custom/element_upgrade_test.dart View 1 chunk +132 lines, -0 lines 0 comments Download
A test/codegen/lib/html/custom/element_upgrade_test.html View 1 chunk +51 lines, -0 lines 0 comments Download
A test/codegen/lib/html/custom/entered_left_view_test.dart View 1 chunk +311 lines, -0 lines 0 comments Download
A test/codegen/lib/html/custom/entered_left_view_test.html View 1 chunk +22 lines, -0 lines 0 comments Download
A test/codegen/lib/html/custom/js_custom_test.dart View 1 chunk +72 lines, -0 lines 0 comments Download
A test/codegen/lib/html/custom/js_custom_test.html View 1 chunk +22 lines, -0 lines 0 comments Download
A test/codegen/lib/html/custom/mirrors_test.dart View 1 chunk +67 lines, -0 lines 0 comments Download
A test/codegen/lib/html/custom/mirrors_test.html View 1 chunk +22 lines, -0 lines 0 comments Download
A test/codegen/lib/html/custom/regress_194523002_test.dart View 1 chunk +35 lines, -0 lines 0 comments Download
A test/codegen/lib/html/custom_element_method_clash_test.dart View 1 chunk +47 lines, -0 lines 0 comments Download
A test/codegen/lib/html/custom_element_method_clash_test.html View 1 chunk +22 lines, -0 lines 0 comments Download
A test/codegen/lib/html/custom_element_name_clash_test.dart View 1 chunk +39 lines, -0 lines 0 comments Download
A test/codegen/lib/html/custom_element_name_clash_test.html View 1 chunk +22 lines, -0 lines 0 comments Download
A test/codegen/lib/html/custom_elements_23127_test.dart View 1 chunk +126 lines, -0 lines 0 comments Download
A test/codegen/lib/html/custom_elements_23127_test.html View 1 chunk +22 lines, -0 lines 0 comments Download
A test/codegen/lib/html/custom_elements_test.dart View 1 chunk +188 lines, -0 lines 0 comments Download
A test/codegen/lib/html/custom_elements_test.html View 1 chunk +22 lines, -0 lines 0 comments Download
A test/codegen/lib/html/custom_tags_test.dart View 1 chunk +49 lines, -0 lines 0 comments Download
A test/codegen/lib/html/dart_object_local_storage_test.dart View 1 chunk +34 lines, -0 lines 0 comments Download
A test/codegen/lib/html/datalistelement_test.dart View 1 chunk +68 lines, -0 lines 0 comments Download
A test/codegen/lib/html/deferred_multi_app.dart View 1 chunk +28 lines, -0 lines 0 comments Download
A test/codegen/lib/html/deferred_multi_app_htmltest.html View 1 chunk +23 lines, -0 lines 0 comments Download
A + test/codegen/lib/html/deferred_multi_app_lib.dart View 1 chunk +5 lines, -4 lines 0 comments Download
A test/codegen/lib/html/document_test.dart View 1 chunk +86 lines, -0 lines 0 comments Download
A test/codegen/lib/html/documentfragment_test.dart View 1 chunk +180 lines, -0 lines 0 comments Download
A test/codegen/lib/html/dom_constructors_test.dart View 1 chunk +12 lines, -0 lines 0 comments Download
A test/codegen/lib/html/dom_isolates_test.dart.child_isolate.dart View 1 chunk +16 lines, -0 lines 0 comments Download
A test/codegen/lib/html/domparser_test.dart View 1 chunk +17 lines, -0 lines 0 comments Download
A test/codegen/lib/html/element_add_test.dart View 1 chunk +270 lines, -0 lines 0 comments Download
A test/codegen/lib/html/element_animate_test.dart View 1 chunk +56 lines, -0 lines 0 comments Download
A test/codegen/lib/html/element_classes_svg_test.dart View 1 chunk +200 lines, -0 lines 0 comments Download
A test/codegen/lib/html/element_classes_test.dart View 1 chunk +397 lines, -0 lines 0 comments Download
A test/codegen/lib/html/element_constructor_1_test.dart View 1 chunk +79 lines, -0 lines 0 comments Download
A test/codegen/lib/html/element_dimensions_test.dart View 1 chunk +263 lines, -0 lines 0 comments Download
A test/codegen/lib/html/element_offset_test.dart View 1 chunk +139 lines, -0 lines 0 comments Download
A test/codegen/lib/html/element_test.dart View 1 chunk +1000 lines, -0 lines 0 comments Download
A test/codegen/lib/html/element_types_constructors1_test.dart View 1 chunk +42 lines, -0 lines 0 comments Download
A test/codegen/lib/html/element_types_constructors2_test.dart View 1 chunk +41 lines, -0 lines 0 comments Download
A test/codegen/lib/html/element_types_constructors3_test.dart View 1 chunk +43 lines, -0 lines 0 comments Download
A test/codegen/lib/html/element_types_constructors4_test.dart View 1 chunk +38 lines, -0 lines 0 comments Download
A test/codegen/lib/html/element_types_constructors5_test.dart View 1 chunk +39 lines, -0 lines 0 comments Download
A test/codegen/lib/html/element_types_constructors6_test.dart View 1 chunk +36 lines, -0 lines 0 comments Download
A test/codegen/lib/html/element_types_test.dart View 1 chunk +84 lines, -0 lines 0 comments Download
A test/codegen/lib/html/event_customevent_test.dart View 1 chunk +86 lines, -0 lines 0 comments Download
A test/codegen/lib/html/event_test.dart View 1 chunk +199 lines, -0 lines 0 comments Download
A test/codegen/lib/html/events_test.dart View 1 chunk +119 lines, -0 lines 0 comments Download
A test/codegen/lib/html/exceptions_test.dart View 1 chunk +18 lines, -0 lines 0 comments Download
A test/codegen/lib/html/fileapi_test.dart View 1 chunk +198 lines, -0 lines 0 comments Download
A test/codegen/lib/html/filereader_test.dart View 1 chunk +43 lines, -0 lines 0 comments Download
A test/codegen/lib/html/filteredelementlist_test.dart View 1 chunk +111 lines, -0 lines 0 comments Download
A test/codegen/lib/html/fontface_loaded_test.dart View 1 chunk +53 lines, -0 lines 0 comments Download
A test/codegen/lib/html/fontface_test.dart View 1 chunk +22 lines, -0 lines 0 comments Download
A test/codegen/lib/html/form_data_test.dart View 1 chunk +85 lines, -0 lines 0 comments Download
A test/codegen/lib/html/form_element_test.dart View 1 chunk +85 lines, -0 lines 0 comments Download
A test/codegen/lib/html/geolocation_test.dart View 1 chunk +18 lines, -0 lines 0 comments Download
A test/codegen/lib/html/hidden_dom_1_test.dart View 1 chunk +45 lines, -0 lines 0 comments Download
A test/codegen/lib/html/hidden_dom_2_test.dart View 1 chunk +48 lines, -0 lines 0 comments Download
A test/codegen/lib/html/history_test.dart View 1 chunk +95 lines, -0 lines 0 comments Download
A test/codegen/lib/html/html.status View 1 chunk +433 lines, -0 lines 0 comments Download
A test/codegen/lib/html/htmlcollection_test.dart View 1 chunk +277 lines, -0 lines 0 comments Download
A test/codegen/lib/html/htmlelement_test.dart View 1 chunk +102 lines, -0 lines 0 comments Download
A test/codegen/lib/html/htmloptionscollection_test.dart View 1 chunk +39 lines, -0 lines 0 comments Download
A test/codegen/lib/html/indexeddb_1_test.dart View 1 chunk +179 lines, -0 lines 0 comments Download
A test/codegen/lib/html/indexeddb_2_test.dart View 1 chunk +106 lines, -0 lines 0 comments Download
A test/codegen/lib/html/indexeddb_3_test.dart View 1 chunk +114 lines, -0 lines 0 comments Download
A test/codegen/lib/html/indexeddb_4_test.dart View 1 chunk +131 lines, -0 lines 0 comments Download
A test/codegen/lib/html/indexeddb_5_test.dart View 1 chunk +183 lines, -0 lines 0 comments Download
A test/codegen/lib/html/input_element_test.dart View 1 chunk +195 lines, -0 lines 0 comments Download
A test/codegen/lib/html/instance_of_test.dart View 1 chunk +70 lines, -0 lines 0 comments Download
A test/codegen/lib/html/interactive_test.dart View 1 chunk +138 lines, -0 lines 0 comments Download
A test/codegen/lib/html/isolates_test.dart View 1 chunk +65 lines, -0 lines 0 comments Download
A test/codegen/lib/html/js_function_getter_test.dart View 1 chunk +109 lines, -0 lines 0 comments Download
A test/codegen/lib/html/js_function_getter_trust_types_test.dart View 1 chunk +72 lines, -0 lines 0 comments Download
A test/codegen/lib/html/js_interop_1_test.dart View 1 chunk +34 lines, -0 lines 0 comments Download
A + test/codegen/lib/html/js_test.dart View 24 chunks +430 lines, -121 lines 0 comments Download
A test/codegen/lib/html/js_typed_interop_anonymous2_exp_test.dart View 1 chunk +53 lines, -0 lines 0 comments Download
A test/codegen/lib/html/js_typed_interop_anonymous2_test.dart View 1 chunk +49 lines, -0 lines 0 comments Download
A test/codegen/lib/html/js_typed_interop_anonymous_exp_test.dart View 1 chunk +37 lines, -0 lines 0 comments Download
A test/codegen/lib/html/js_typed_interop_anonymous_test.dart View 1 chunk +33 lines, -0 lines 0 comments Download
A test/codegen/lib/html/js_typed_interop_anonymous_unreachable_exp_test.dart View 1 chunk +35 lines, -0 lines 0 comments Download
A test/codegen/lib/html/js_typed_interop_anonymous_unreachable_test.dart View 1 chunk +31 lines, -0 lines 0 comments Download
A test/codegen/lib/html/js_typed_interop_default_arg_test.dart View 1 chunk +58 lines, -0 lines 0 comments Download
A test/codegen/lib/html/js_typed_interop_default_arg_test_default_value_multi.dart View 1 chunk +59 lines, -0 lines 0 comments Download
A test/codegen/lib/html/js_typed_interop_default_arg_test_explicit_argument_multi.dart View 1 chunk +59 lines, -0 lines 0 comments Download
A test/codegen/lib/html/js_typed_interop_default_arg_test_none_multi.dart View 1 chunk +59 lines, -0 lines 0 comments Download
A test/codegen/lib/html/js_typed_interop_side_cast_exp_test.dart View 1 chunk +54 lines, -0 lines 0 comments Download
A test/codegen/lib/html/js_typed_interop_side_cast_test.dart View 1 chunk +48 lines, -0 lines 0 comments Download
A test/codegen/lib/html/js_typed_interop_test.dart View 1 chunk +413 lines, -0 lines 0 comments Download
A + test/codegen/lib/html/json_helper.dart View 1 chunk +4 lines, -4 lines 0 comments Download
A test/codegen/lib/html/keyboard_event_test.dart View 1 chunk +95 lines, -0 lines 0 comments Download
A test/codegen/lib/html/localstorage_test.dart View 1 chunk +108 lines, -0 lines 0 comments Download
A test/codegen/lib/html/location_test.dart View 1 chunk +33 lines, -0 lines 0 comments Download
A test/codegen/lib/html/media_stream_test.dart View 1 chunk +49 lines, -0 lines 0 comments Download
A test/codegen/lib/html/mediasource_test.dart View 1 chunk +42 lines, -0 lines 0 comments Download
A test/codegen/lib/html/messageevent_test.dart View 1 chunk +23 lines, -0 lines 0 comments Download
A test/codegen/lib/html/mirrors_js_typed_interop_test.dart View 1 chunk +49 lines, -0 lines 0 comments Download
A test/codegen/lib/html/mouse_event_test.dart View 1 chunk +20 lines, -0 lines 0 comments Download
A test/codegen/lib/html/mutationobserver_test.dart View 1 chunk +112 lines, -0 lines 0 comments Download
A test/codegen/lib/html/native_gc_test.dart View 1 chunk +59 lines, -0 lines 0 comments Download
A test/codegen/lib/html/navigator_test.dart View 1 chunk +12 lines, -0 lines 0 comments Download
A test/codegen/lib/html/no_linked_scripts_htmltest.html View 1 chunk +33 lines, -0 lines 0 comments Download
A test/codegen/lib/html/node_test.dart View 1 chunk +360 lines, -0 lines 0 comments Download
A test/codegen/lib/html/node_validator_important_if_you_suppress_make_the_bug_critical_test.dart View 1 chunk +570 lines, -0 lines 0 comments Download
A test/codegen/lib/html/non_instantiated_is_test.dart View 1 chunk +20 lines, -0 lines 0 comments Download
A test/codegen/lib/html/notification_test.dart View 1 chunk +49 lines, -0 lines 0 comments Download
A test/codegen/lib/html/performance_api_test.dart View 1 chunk +33 lines, -0 lines 0 comments Download
A test/codegen/lib/html/postmessage_structured_test.dart View 1 chunk +194 lines, -0 lines 0 comments Download
A test/codegen/lib/html/query_test.dart View 1 chunk +57 lines, -0 lines 0 comments Download
A test/codegen/lib/html/queryall_test.dart View 1 chunk +87 lines, -0 lines 0 comments Download
A test/codegen/lib/html/range_test.dart View 1 chunk +29 lines, -0 lines 0 comments Download
A test/codegen/lib/html/request_animation_frame_test.dart View 1 chunk +55 lines, -0 lines 0 comments Download
A test/codegen/lib/html/resource_data.txt View 1 chunk +1 line, -0 lines 0 comments Download
A test/codegen/lib/html/resource_http_test.dart View 1 chunk +41 lines, -0 lines 0 comments Download
A test/codegen/lib/html/rtc_test.dart View 1 chunk +49 lines, -0 lines 0 comments Download
A test/codegen/lib/html/scripts_htmltest.html View 1 chunk +24 lines, -0 lines 0 comments Download
A test/codegen/lib/html/scripts_test_dart.dart View 1 chunk +16 lines, -0 lines 0 comments Download
A test/codegen/lib/html/scripts_test_js.js View 1 chunk +12 lines, -0 lines 0 comments Download
A test/codegen/lib/html/selectelement_test.dart View 1 chunk +77 lines, -0 lines 0 comments Download
A test/codegen/lib/html/serialized_script_value_test.dart View 1 chunk +52 lines, -0 lines 0 comments Download
A test/codegen/lib/html/shadow_dom_test.dart View 1 chunk +95 lines, -0 lines 0 comments Download
A test/codegen/lib/html/shadowroot_test.dart View 1 chunk +29 lines, -0 lines 0 comments Download
A test/codegen/lib/html/small.mp4 View Binary file 0 comments Download
A test/codegen/lib/html/small.webm View Binary file 0 comments Download
A test/codegen/lib/html/speechrecognition_test.dart View 1 chunk +44 lines, -0 lines 0 comments Download
A test/codegen/lib/html/storage_test.dart View 1 chunk +28 lines, -0 lines 0 comments Download
A test/codegen/lib/html/streams_test.dart View 1 chunk +276 lines, -0 lines 0 comments Download
A test/codegen/lib/html/svg_test.dart View 1 chunk +133 lines, -0 lines 0 comments Download
A test/codegen/lib/html/svgelement_test.dart View 1 chunk +474 lines, -0 lines 0 comments Download
A test/codegen/lib/html/table_test.dart View 1 chunk +61 lines, -0 lines 0 comments Download
A test/codegen/lib/html/text_event_test.dart View 1 chunk +18 lines, -0 lines 0 comments Download
A test/codegen/lib/html/touchevent_test.dart View 1 chunk +29 lines, -0 lines 0 comments Download
A test/codegen/lib/html/track_element_constructor_test.dart View 1 chunk +30 lines, -0 lines 0 comments Download
A test/codegen/lib/html/transferables_test.dart View 1 chunk +35 lines, -0 lines 0 comments Download
A test/codegen/lib/html/transition_event_test.dart View 1 chunk +43 lines, -0 lines 0 comments Download
A test/codegen/lib/html/trusted_html_tree_sanitizer_test.dart View 1 chunk +64 lines, -0 lines 0 comments Download
A test/codegen/lib/html/two_scripts_htmltest.html View 1 chunk +25 lines, -0 lines 0 comments Download
A + test/codegen/lib/html/two_scripts_test_first.dart View 1 chunk +6 lines, -5 lines 0 comments Download
A + test/codegen/lib/html/two_scripts_test_second.dart View 1 chunk +6 lines, -5 lines 0 comments Download
A test/codegen/lib/html/typed_arrays_1_test.dart View 1 chunk +72 lines, -0 lines 0 comments Download
A test/codegen/lib/html/typed_arrays_2_test.dart View 1 chunk +86 lines, -0 lines 0 comments Download
A test/codegen/lib/html/typed_arrays_3_test.dart View 1 chunk +46 lines, -0 lines 0 comments Download
A test/codegen/lib/html/typed_arrays_4_test.dart View 1 chunk +48 lines, -0 lines 0 comments Download
A test/codegen/lib/html/typed_arrays_5_test.dart View 1 chunk +50 lines, -0 lines 0 comments Download
A test/codegen/lib/html/typed_arrays_arraybuffer_test.dart View 1 chunk +44 lines, -0 lines 0 comments Download
A test/codegen/lib/html/typed_arrays_dataview_test.dart View 1 chunk +92 lines, -0 lines 0 comments Download
A test/codegen/lib/html/typed_arrays_range_checks_test.dart View 1 chunk +77 lines, -0 lines 0 comments Download
A test/codegen/lib/html/typed_arrays_simd_test.dart View 1 chunk +85 lines, -0 lines 0 comments Download
A test/codegen/lib/html/typing_test.dart View 1 chunk +37 lines, -0 lines 0 comments Download
A test/codegen/lib/html/unknownelement_test.dart View 1 chunk +34 lines, -0 lines 0 comments Download
A test/codegen/lib/html/uri_test.dart View 1 chunk +16 lines, -0 lines 0 comments Download
A test/codegen/lib/html/url_test.dart View 1 chunk +71 lines, -0 lines 0 comments Download
A test/codegen/lib/html/util.dart View 1 chunk +19 lines, -0 lines 0 comments Download
A test/codegen/lib/html/utils.dart View 1 chunk +176 lines, -0 lines 0 comments Download
A test/codegen/lib/html/webgl_1_test.dart View 1 chunk +111 lines, -0 lines 0 comments Download
A test/codegen/lib/html/websocket_test.dart View 1 chunk +52 lines, -0 lines 0 comments Download
A test/codegen/lib/html/websql_test.dart View 1 chunk +141 lines, -0 lines 0 comments Download
A test/codegen/lib/html/wheelevent_test.dart View 1 chunk +58 lines, -0 lines 0 comments Download
A test/codegen/lib/html/window_eq_test.dart View 1 chunk +14 lines, -0 lines 0 comments Download
A test/codegen/lib/html/window_mangling_test.dart View 1 chunk +35 lines, -0 lines 0 comments Download
A test/codegen/lib/html/window_nosuchmethod_test.dart View 1 chunk +55 lines, -0 lines 0 comments Download
A test/codegen/lib/html/window_test.dart View 1 chunk +17 lines, -0 lines 0 comments Download
A test/codegen/lib/html/worker_api_test.dart View 1 chunk +32 lines, -0 lines 0 comments Download
A test/codegen/lib/html/worker_test.dart View 1 chunk +52 lines, -0 lines 0 comments Download
A test/codegen/lib/html/wrapping_collections_test.dart View 1 chunk +27 lines, -0 lines 0 comments Download
A test/codegen/lib/html/xhr_cross_origin_data.txt View 1 chunk +1 line, -0 lines 0 comments Download
A test/codegen/lib/html/xhr_cross_origin_test.dart View 1 chunk +110 lines, -0 lines 0 comments Download
A test/codegen/lib/html/xhr_test.dart View 1 chunk +259 lines, -0 lines 0 comments Download
A test/codegen/lib/html/xsltprocessor_test.dart View 1 chunk +31 lines, -0 lines 0 comments Download
M test/codegen/unittest.dart View 4 chunks +158 lines, -1 line 0 comments Download
M test/codegen_test.dart View 2 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Jacob
All tests are added except for js_array_test and one other js test. Plenty of tests ...
4 years, 7 months ago (2016-04-28 17:54:55 UTC) #2
vsm
lgtm! https://codereview.chromium.org/1930043002/diff/1/karma.conf.js File karma.conf.js (right): https://codereview.chromium.org/1930043002/diff/1/karma.conf.js#newcode30 karma.conf.js:30: 'test/codegen/expect/lib-html-all.js', should be changed to glob as i ...
4 years, 7 months ago (2016-04-28 19:09:22 UTC) #3
Jacob
https://codereview.chromium.org/1930043002/diff/1/karma.conf.js File karma.conf.js (right): https://codereview.chromium.org/1930043002/diff/1/karma.conf.js#newcode30 karma.conf.js:30: 'test/codegen/expect/lib-html-all.js', On 2016/04/28 19:09:21, vsm wrote: > should be ...
4 years, 7 months ago (2016-04-28 19:30:21 UTC) #4
Jacob
4 years, 7 months ago (2016-04-28 19:30:32 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
cfab62eeb528590e402b6f907ecd3ff94cf0c79c.

Powered by Google App Engine
This is Rietveld 408576698