Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 19300002: ES6: Add support for explicit octal and binary integer literals (Closed)

Created:
7 years, 5 months ago by arv (Not doing code reviews)
Modified:
7 years, 5 months ago
Reviewers:
rossberg
CC:
v8-dev
Visibility:
Public.

Description

Add support for explicit octal and binary integer literals http://people.mozilla.org/~jorendorff/es6-draft.html#sec-7.8.3 ES6 extends the numeric literals to support explicit support for binary and octal literals using the following syntax: 0b10101 0o777 This is currently behind the flag, --harmony-numeric-literals BUG=2783 R=rossberg@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=15772

Patch Set 1 #

Total comments: 1

Patch Set 2 : Added flag and mjsunit test #

Patch Set 3 : Make sure Number does not allow 0b when flag is off #

Patch Set 4 : Fix long lines #

Unified diffs Side-by-side diffs Delta from patch set Stats (+263 lines, -108 lines) Patch
M src/char-predicates.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/char-predicates-inl.h View 1 chunk +12 lines, -0 lines 0 comments Download
M src/conversions.h View 2 chunks +9 lines, -2 lines 0 comments Download
M src/conversions-inl.h View 2 chunks +27 lines, -1 line 0 comments Download
M src/flag-definitions.h View 1 2 3 2 chunks +3 lines, -0 lines 0 comments Download
M src/parser.h View 1 2 chunks +6 lines, -0 lines 0 comments Download
M src/parser.cc View 1 5 chunks +8 lines, -2 lines 0 comments Download
M src/preparser.h View 1 2 chunks +6 lines, -0 lines 0 comments Download
M src/preparser.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/runtime.cc View 1 2 3 1 chunk +7 lines, -1 line 0 comments Download
M src/scanner.h View 1 2 chunks +8 lines, -1 line 0 comments Download
M src/scanner.cc View 1 5 chunks +27 lines, -5 lines 0 comments Download
M test/cctest/test-conversions.cc View 1 2 3 5 chunks +89 lines, -38 lines 0 comments Download
M test/cctest/test-parsing.cc View 1 2 chunks +4 lines, -1 line 0 comments Download
A + test/mjsunit/harmony/numeric-literals.js View 1 2 1 chunk +44 lines, -45 lines 0 comments Download
A + test/mjsunit/harmony/numeric-literals-off.js View 1 2 3 1 chunk +9 lines, -11 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
arv (Not doing code reviews)
7 years, 5 months ago (2013-07-15 22:28:30 UTC) #1
rossberg
Looks good, but should go behind a flag for now. I suggest --harmony-literals. https://codereview.chromium.org/19300002/diff/1/src/runtime.cc File ...
7 years, 5 months ago (2013-07-16 13:26:25 UTC) #2
arv (Not doing code reviews)
On 2013/07/16 13:26:25, rossberg wrote: > Looks good, but should go behind a flag for ...
7 years, 5 months ago (2013-07-16 14:06:04 UTC) #3
arv (Not doing code reviews)
PTAL
7 years, 5 months ago (2013-07-16 15:44:12 UTC) #4
arv (Not doing code reviews)
Ping?
7 years, 5 months ago (2013-07-17 15:28:32 UTC) #5
rossberg
LGTM, will land tomorrow
7 years, 5 months ago (2013-07-17 17:05:52 UTC) #6
rossberg
Arv, there are plenty of line length violations. Can you please fix those?
7 years, 5 months ago (2013-07-18 17:30:54 UTC) #7
arv (Not doing code reviews)
Fixed the long lines. PTAL
7 years, 5 months ago (2013-07-18 17:50:13 UTC) #8
rossberg
Committed patchset #4 manually as r15772 (presubmit successful).
7 years, 5 months ago (2013-07-19 09:57:47 UTC) #9
rossberg
7 years, 5 months ago (2013-07-19 09:58:13 UTC) #10
Message was sent while issue was closed.
On 2013/07/18 17:50:13, arv wrote:
> Fixed the long lines.

Thanks, landed.

Powered by Google App Engine
This is Rietveld 408576698