Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1929993002: Add Skia to list of can-be-patched projects in chromium checkout. (Closed)

Created:
4 years, 7 months ago by rmistry
Modified:
4 years, 7 months ago
Reviewers:
tandrii(chromium)
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add Skia to list of can-be-patched projects in chromium checkout. BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300287

Patch Set 1 : Initial upload #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M recipe_modules/gclient/config.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
rmistry
4 years, 7 months ago (2016-04-28 16:24:28 UTC) #2
tandrii(chromium)
LGTM I also recommend you add a test into chromium trybot similar to v8 once ...
4 years, 7 months ago (2016-04-28 16:42:03 UTC) #3
rmistry
On 2016/04/28 16:42:03, tandrii(chromium) wrote: > LGTM > > I also recommend you add a ...
4 years, 7 months ago (2016-04-28 16:43:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1929993002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1929993002/1
4 years, 7 months ago (2016-04-28 16:43:51 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-04-28 16:46:48 UTC) #8
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=300287

Powered by Google App Engine
This is Rietveld 408576698