Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 1929963005: Serialize default constructors separately. (Closed)

Created:
4 years, 7 months ago by Johnni Winther
Modified:
4 years, 7 months ago
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -21 lines) Patch
M pkg/compiler/lib/src/serialization/element_serialization.dart View 4 chunks +7 lines, -11 lines 0 comments Download
M pkg/compiler/lib/src/serialization/keys.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/serialization/modelz.dart View 2 chunks +14 lines, -9 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Johnni Winther
4 years, 7 months ago (2016-04-29 11:25:04 UTC) #2
Siggi Cherem (dart-lang)
lgtm
4 years, 7 months ago (2016-04-29 23:59:30 UTC) #3
Johnni Winther
4 years, 7 months ago (2016-04-30 09:11:19 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
edf7d43ebaee23fac9dd68909be4ef646965ac3b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698