Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Issue 1929963004: Revert of Split protoc into library and executable. (Closed)

Created:
4 years, 7 months ago by Justin Donnelly
Modified:
4 years, 7 months ago
Reviewers:
xyzzyz, Peter Kasting
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Split protoc into library and executable. (patchset #4 id:60001 of https://codereview.chromium.org/1923733002/ ) Reason for revert: Broke compile on WebKit Linux MSAN (and others?) Original issue's description: > Split protoc into library and executable. > > Similarly to the upstream BUILD file, we split the protoc compiler into > a library and executable. The purpose is to allow protoc compiler > plugins (see plugin.h). > > BUG=597321 TBR=pkasting@chromium.org,xyzzyz@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=597321 Committed: https://crrev.com/a4d56705f4c988bf48ec2c4856f2b07a9a23ad1f Cr-Commit-Position: refs/heads/master@{#390486}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+195 lines, -222 lines) Patch
M third_party/protobuf/BUILD.gn View 3 chunks +5 lines, -19 lines 0 comments Download
M third_party/protobuf/protobuf.gyp View 1 chunk +190 lines, -203 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Justin Donnelly
Created Revert of Split protoc into library and executable.
4 years, 7 months ago (2016-04-28 21:31:43 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1929963004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1929963004/1
4 years, 7 months ago (2016-04-28 21:32:24 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-04-28 21:32:57 UTC) #3
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:21:32 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a4d56705f4c988bf48ec2c4856f2b07a9a23ad1f
Cr-Commit-Position: refs/heads/master@{#390486}

Powered by Google App Engine
This is Rietveld 408576698