Change bool type to fix warnings.

Change bool type to fix warnings.

Switching the Is{SHIFT|CTRL|ALT|}KeyDown methods to bool from FX_BOOL generated

cfx_systemhandler.cpp(129): warning C4800: 'FX_BOOL': forcing value to bool
'true' or 'false' (performance warning)

on the win_chromium_x64_rel_ng and win8_chromium_ng bots. This CL switches
back to FX_BOOL. Attempting to move everything to bool has huge ripple effects.

I removed IsINSERTKeyDown as it was always false.

Committed: https://pdfium.googlesource.com/pdfium/+/224bc5a983a02c0da3ecc0ee55b6c8b1fe500980

[dsinclair, 2016-04-28 13:49:11]

dsinclair@chromium.org changed reviewers:
+ thestig@chromium.org, tsepez@chromium.org

[dsinclair, 2016-04-28 13:49:12]

PTAL.

[Tom Sepez, 2016-04-28 16:24:54]

https://codereview.chromium.org/1929963002/diff/1/fpdfsdk/cfx_systemhandler.cpp
File fpdfsdk/cfx_systemhandler.cpp (right):

https://codereview.chromium.org/1929963002/diff/1/fpdfsdk/cfx_systemhandler.c...
fpdfsdk/cfx_systemhandler.cpp:129: return m_pEnv->FFI_IsSHIFTKeyDown(nFlag);
How about keeping the return type as bool, and changing this to
  return !!m_pEnv->FFI_IsShiftKeyDown(nFlag);

[dsinclair, 2016-04-28 17:14:50]

https://codereview.chromium.org/1929963002/diff/1/fpdfsdk/cfx_systemhandler.cpp
File fpdfsdk/cfx_systemhandler.cpp (right):

https://codereview.chromium.org/1929963002/diff/1/fpdfsdk/cfx_systemhandler.c...
fpdfsdk/cfx_systemhandler.cpp:129: return m_pEnv->FFI_IsSHIFTKeyDown(nFlag);
On 2016/04/28 16:24:54, Tom Sepez wrote:
> How about keeping the return type as bool, and changing this to
>   return !!m_pEnv->FFI_IsShiftKeyDown(nFlag);

Done.

[Tom Sepez, 2016-04-28 17:52:44]

lgtm

[dsinclair, 2016-04-28 18:04:31]

The CQ bit was checked by dsinclair@chromium.org

[commit-bot: I haz the power, 2016-04-28 18:04:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1929963002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1929963002/20001

[commit-bot: I haz the power, 2016-04-28 18:04:54]

Description was changed from

==========
Change bool type to fix warnings.

Switching the Is{SHIFT|CTRL|ALT|}KeyDown methods to bool from FX_BOOL generated

cfx_systemhandler.cpp(129): warning C4800: 'FX_BOOL': forcing value to bool
'true' or 'false' (performance warning)

on the win_chromium_x64_rel_ng and win8_chromium_ng bots. This CL switches
back to FX_BOOL. Attempting to move everything to bool has huge ripple effects.

I removed IsINSERTKeyDown as it was always false.
==========

to

==========
Change bool type to fix warnings.

Switching the Is{SHIFT|CTRL|ALT|}KeyDown methods to bool from FX_BOOL generated

cfx_systemhandler.cpp(129): warning C4800: 'FX_BOOL': forcing value to bool
'true' or 'false' (performance warning)

on the win_chromium_x64_rel_ng and win8_chromium_ng bots. This CL switches
back to FX_BOOL. Attempting to move everything to bool has huge ripple effects.

I removed IsINSERTKeyDown as it was always false.

Committed:
https://pdfium.googlesource.com/pdfium/+/224bc5a983a02c0da3ecc0ee55b6c8b1fe50...
==========

[commit-bot: I haz the power, 2016-04-28 18:04:54]

Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/224bc5a983a02c0da3ecc0ee55b6c8b1fe50...