Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1614)

Unified Diff: mojo/devtools/common/mojo_debug

Issue 1929943002: Allow mojo_debug to run on mac (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/devtools/common/mojo_debug
diff --git a/mojo/devtools/common/mojo_debug b/mojo/devtools/common/mojo_debug
index dc1000b8dd59b6b27c0b04bd53cac7b06b70cec8..cf24971b6c9c5471f93c4c141e0baaf6b3660266 100755
--- a/mojo/devtools/common/mojo_debug
+++ b/mojo/devtools/common/mojo_debug
@@ -7,6 +7,7 @@ import argparse
import codecs
import logging
import os.path
+import platform
import requests
import signal
import subprocess
@@ -194,8 +195,7 @@ def _gdb_attach(args):
# TODO(etiennej): Always select the most recent toolchain?
'arm-linux-androideabi-4.9',
'prebuilt',
- # TODO(etiennej): DEPS mac NDK and use it on macs.
- 'linux-x86_64',
+ '%s-%s' % (platform.system().lower(), platform.machine()),
'bin',
'arm-linux-androideabi-gdb')
python_gdb_script_path = os.path.join(os.path.dirname(__file__),
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698