Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1036)

Issue 192993002: Move ParseObjectLiteral to ParserBase. (Closed)

Created:
6 years, 9 months ago by marja
Modified:
6 years, 9 months ago
Reviewers:
ulan
CC:
v8-dev
Visibility:
Public.

Description

Move ParseObjectLiteral to ParserBase. BUG=v8:3126 LOG=N R=ulan@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19805

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : rebased on top of rossberg@s changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+304 lines, -268 lines) Patch
M src/func-name-inferrer.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M src/parser.h View 1 2 7 chunks +40 lines, -4 lines 0 comments Download
M src/parser.cc View 1 2 6 chunks +15 lines, -171 lines 0 comments Download
M src/preparser.h View 1 2 11 chunks +231 lines, -3 lines 0 comments Download
M src/preparser.cc View 1 2 3 chunks +14 lines, -90 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
marja
ulan, ptal
6 years, 9 months ago (2014-03-11 10:39:17 UTC) #1
ulan
lgtm
6 years, 9 months ago (2014-03-11 14:31:02 UTC) #2
marja
6 years, 9 months ago (2014-03-11 15:40:49 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 manually as r19805 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698