Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Unified Diff: third_party/WebKit/Source/core/dom/Document.cpp

Issue 1929843002: Events should have an initialized flag. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Modified assert Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/dom/Document.cpp
diff --git a/third_party/WebKit/Source/core/dom/Document.cpp b/third_party/WebKit/Source/core/dom/Document.cpp
index 86461d98f0a7853cde6527ded0bac20f16c50ce8..58dab753fdac671aca75b33e8469f85db4a46631 100644
--- a/third_party/WebKit/Source/core/dom/Document.cpp
+++ b/third_party/WebKit/Source/core/dom/Document.cpp
@@ -3946,8 +3946,10 @@ Event* Document::createEvent(ExecutionContext* executionContext, const String& e
Event* event = nullptr;
for (const auto& factory : eventFactories()) {
event = factory->create(executionContext, eventType);
- if (event)
+ if (event) {
+ event->unsetInitializedFlag();
tkent 2016/05/02 00:19:27 This code implements what the specification says a
ramya.v 2016/05/02 05:31:44 Done.
return event;
+ }
}
exceptionState.throwDOMException(NotSupportedError, "The provided event type ('" + eventType + "') is invalid.");
return nullptr;

Powered by Google App Engine
This is Rietveld 408576698