Sampling heap profiler: Fix potential crash on accessing scripts.

Sampling heap profiler: Fix potential crash on accessing scripts.

Do not hold bare pointers to scripts during sampling heap tree construction,
as string conversions may lead to an allocation that in turn could cause GC
which renders all pointers invalid.

Committed: https://crrev.com/7961e2e9232c301c1bf8f343d20185e0bdff30c9
Cr-Commit-Position: refs/heads/master@{#35883}

[alph, 2016-04-28 01:19:06]

The CQ bit was checked by alph@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-28 01:19:13]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1929813002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1929813002/1

[commit-bot: I haz the power, 2016-04-28 02:07:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-28 02:07:24]

Dry run: This issue passed the CQ dry run.

[alph, 2016-04-28 07:36:39]

alph@chromium.org changed reviewers:
+ ofrobots@google.com, ulan@chromium.org

[ulan, 2016-04-28 09:17:37]

lgtm

[ofrobots, 2016-04-28 18:53:18]

On 2016/04/28 09:17:37, ulan wrote:
> lgtm

lgtm.

[alph, 2016-04-28 21:43:42]

The CQ bit was checked by alph@chromium.org

[commit-bot: I haz the power, 2016-04-28 21:43:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1929813002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1929813002/1

[commit-bot: I haz the power, 2016-04-28 21:46:13]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-05-01 22:03:04]

Description was changed from

==========
Sampling heap profiler: Fix potential crash on accessing scripts.

Do not hold bare pointers to scripts during sampling heap tree construction,
as string conversions may lead to an allocation that in turn could cause GC
which renders all pointers invalid.
==========

to

==========
Sampling heap profiler: Fix potential crash on accessing scripts.

Do not hold bare pointers to scripts during sampling heap tree construction,
as string conversions may lead to an allocation that in turn could cause GC
which renders all pointers invalid.

Committed: https://crrev.com/7961e2e9232c301c1bf8f343d20185e0bdff30c9
Cr-Commit-Position: refs/heads/master@{#35883}
==========

[commit-bot: I haz the power, 2016-05-01 22:03:05]

Patchset 1 (id:??) landed as
https://crrev.com/7961e2e9232c301c1bf8f343d20185e0bdff30c9
Cr-Commit-Position: refs/heads/master@{#35883}