runtime/vm/debugger.cc - Issue 1929743002: Assert that background compiler is not adding closure functions; stop background compiler when deop…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/debugger.cc

Issue 1929743002: Assert that background compiler is not adding closure functions; stop background compiler when deop… (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/debugger.cc

diff --git a/runtime/vm/debugger.cc b/runtime/vm/debugger.cc

index 6afad6318c9defa6c385a0259f4a07e80e987f67..3cb92b266c8c63ac00f713a5fbea6abb456e9610 100644

--- a/runtime/vm/debugger.cc

+++ b/runtime/vm/debugger.cc

@@ -1402,6 +1402,7 @@ RawFunction* Debugger::ResolveFunction(const Library& library,

// that inline the function that contains the newly created breakpoint.

// We currently don't have this info so we deoptimize all functions.

void Debugger::DeoptimizeWorld() {

+ BackgroundCompiler::Stop(isolate_);

DeoptimizeFunctionsOnStack();

// Iterate over all classes, deoptimize functions.

// TODO(hausner): Could possibly be combined with RemoveOptimizedCode()

« no previous file with comments | « no previous file | runtime/vm/isolate.cc » ('j') | no next file with comments »