Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issue 1929743002: Assert that background compiler is not adding closure functions; stop background compiler when deop… (Closed)

Created:
4 years, 7 months ago by srdjan
Modified:
4 years, 7 months ago
Reviewers:
regis, hausner
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Assert that background compiler is not adding closure functions; stop background compiler when deoptimizing the world. BUG= R=regis@google.com Committed: https://github.com/dart-lang/sdk/commit/23d296c144477529c92c1a843b11f0a750c984bf

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M runtime/vm/debugger.cc View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/isolate.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
srdjan
4 years, 7 months ago (2016-04-27 22:56:36 UTC) #2
regis
LGTM
4 years, 7 months ago (2016-04-27 23:13:19 UTC) #3
srdjan
4 years, 7 months ago (2016-04-27 23:23:57 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
23d296c144477529c92c1a843b11f0a750c984bf (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698